Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Basic support for structs #17

Closed
6 tasks done
revans2 opened this issue May 28, 2020 · 8 comments
Closed
6 tasks done

[FEA] Basic support for structs #17

revans2 opened this issue May 28, 2020 · 8 comments
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P0 Must have for release SQL part of the SQL/Dataframe plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented May 28, 2020 •
edited by sameerz
Loading

Basic functionality for struct support
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels May 28, 2020
This was referenced May 29, 2020
Closed
Closed
Closed
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jul 6, 2020
@sameerz
Copy link
Collaborator

sameerz commented Jul 6, 2020

Adding to 0.2, depending on the scope of the work, may continue to 0.3.

@sameerz sameerz added the P0 Must have for release label Jul 22, 2020
@sameerz
Copy link
Collaborator

sameerz commented Jul 22, 2020

Depends on rapidsai/cudf#5700

@revans2
Copy link
Collaborator Author

revans2 commented Aug 7, 2020

@mythrocks realistically do we have any chance to get rapidsai/cudf#5700 in and JNI bindings on it by cudf-0.15? If not we need to move this to release 0.3

@sameerz
Copy link
Collaborator

sameerz commented Dec 5, 2020

This issue is very broad. Some progress has been made. We need to break this up into additional tasks.

@sameerz sameerz changed the title [FEA] Support for structs [FEA] Basic support for structs Jan 5, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Jan 6, 2021

We are not going to support nested types for CreateNamedStruct yet because cudf does not support scalar values for nested types

@kuhushukla
Copy link
Collaborator

We allow structs to pass through shuffle and we don't support partitioning on structs.

@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Feb 18, 2021
@devavret
Copy link

it's rapidsai/cudf#7461 now

@sameerz
Copy link
Collaborator

sameerz commented May 11, 2021

Closing this as we have basic support for structs. We will open new issues for additional struct work.

@sameerz sameerz closed this as completed May 11, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to a552afb (NVIDIA#17)
0d0eb43 
Signed-off-by: spark-rapids automation <[email protected]>
wjxiz1992 added a commit to wjxiz1992/spark-rapids that referenced this issue Dec 18, 2023
@wjxiz1992
Capture nsys for Q6 (NVIDIA#17)
7ae7592 
* capture nsys report

Signed-off-by: Allen Xu <[email protected]>

* remove sleep

Signed-off-by: Allen Xu <[email protected]>

* only for Q6

Signed-off-by: Allen Xu <[email protected]>

---------

Signed-off-by: Allen Xu <[email protected]>
binmahone added a commit to binmahone/spark-rapids that referenced this issue Jun 25, 2024
@binmahone
NVIDIA#10950 for liyuan/0612-base-local (NVIDIA#17)
c37cfa2 
* add a heristic to skip agg pass

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* commit doc change

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* refine naming

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* fix only reduction case

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* fix compile

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* fix

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* clean

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* fix doc

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* reduce premergeci2

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* reduce premergeci2, 2

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* use test_parallel to workaround flaky array test

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* address review comment

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* remove comma

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* workaround for  ci_scala213

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

* fix conflict

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>

---------

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P0 Must have for release SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@devavret @revans2 @sameerz @kuhushukla