Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Better way to test fallback #167

Closed
revans2 opened this issue Jun 12, 2020 · 2 comments · Fixed by #174
Closed

[FEA] Better way to test fallback #167

revans2 opened this issue Jun 12, 2020 · 2 comments · Fixed by #174
Assignees
@revans2
Labels
feature request New feature or request SQL part of the SQL/Dataframe plugin test Only impacts tests

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 12, 2020

Is your feature request related to a problem? Please describe.
We need a better way to test that we fall back to the CPU. Right now there are a lot of ways to do this and none of them are that good. We should come up with a standard way of doing this and make it easy to use.
@revans2 revans2 added feature request New feature or request SQL part of the SQL/Dataframe plugin test Only impacts tests labels Jun 12, 2020
@revans2 revans2 self-assigned this Jun 12, 2020
@kuhushukla
Copy link
Collaborator

Would this be on scala side or python side or both?

@revans2
Copy link
Collaborator Author

revans2 commented Jun 12, 2020

Still need to figure it out. Hopefully it is something that will work for both, but need to see.

@revans2 revans2 mentioned this issue Jun 15, 2020
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to c4a9b6a (NVIDIA#167)
99248db 
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
feature request New feature or request SQL part of the SQL/Dataframe plugin test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added in fallback tests
2 participants
@revans2 @kuhushukla