Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Decimal support for multiply int div, add, subtract and null safe equals #1329

Closed
7 of 10 tasks
revans2 opened this issue Dec 8, 2020 · 1 comment · Fixed by #1561
Closed
7 of 10 tasks

[FEA] Decimal support for multiply int div, add, subtract and null safe equals #1329

revans2 opened this issue Dec 8, 2020 · 1 comment · Fixed by #1561
Assignees
@rwlee
Labels
feature request New feature or request
Milestone
Jan 18 - Jan 29

Comments

@revans2
Copy link
Collaborator

revans2 commented Dec 8, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
We support a few binary ops for decimal, like comparisons, but we should look into support for the others that we support.

Specifically

  • multiply
  • integral divide
  • subtract
  • add

Next priority is

  • EqualsNullSafe (again follow on issue if this is not supported right now)

This will also require us to support PromotePrecision (which is just metadata and a noop is OK) and CheckOverflow (which for the most part this should be fine for binary ops, but we need to check that it is OK for other operations where it might be inserted)

The following will be done as a part of a follow on issue #1572
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 8, 2020
@revans2 revans2 mentioned this issue Dec 8, 2020
Closed
27 tasks
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Dec 15, 2020
@sameerz sameerz added this to the Jan 18 - Jan 29 milestone Dec 16, 2020
@rwlee rwlee self-assigned this Jan 7, 2021
@rwlee
Copy link
Contributor

rwlee commented Jan 7, 2021

Starting with decimal support for add.

This was linked to pull requests Jan 21, 2021
Decimal support for add and subtract #1561
Merged
Add in support for Decimal Multiply and DIV #1564
Merged
@revans2 revans2 reopened this Jan 22, 2021
@revans2 revans2 removed a link to a pull request Jan 22, 2021
Add in support for Decimal Multiply and DIV #1564
Merged
@revans2 revans2 mentioned this issue Jan 22, 2021
Closed
3 tasks
@revans2 revans2 changed the title [FEA] Support the rest of the decimal binary ops [FEA] Decimal support for multiply int div, add, subtract and null safe equals Jan 22, 2021
@revans2 revans2 closed this as completed Jan 22, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Merge pull request NVIDIA#1329 from NVIDIA/bot-auto-merge-branch-23.08
7ce16ec 
[auto-merge] bot-auto-merge-branch-23.08 to branch-23.10 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwlee rwlee

Labels
feature request New feature or request
Projects
None yet
Milestone
Jan 18 - Jan 29
Development

Successfully merging a pull request may close this issue.

Decimal support for add and subtract rwlee/spark-rapids
3 participants
@revans2 @sameerz @rwlee