Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUDIT] uncacheTableOrView changed in CommandUtils #10710

Closed
Tracked by #9259
razajafri opened this issue Apr 15, 2024 · 1 comment · Fixed by #10863
Closed
Tracked by #9259

[AUDIT] uncacheTableOrView changed in CommandUtils #10710

razajafri opened this issue Apr 15, 2024 · 1 comment · Fixed by #10863
Assignees
@mythrocks
Labels
audit_4.0.0 Audit related tasks for 4.0.0 bug Something isn't working

Comments

@razajafri
Copy link
Collaborator

Spark made a change in apache/spark@6d41866e631, modifying the parameters to the uncacheTableOrView. We depend on this method and we should make the appropriate change.
@razajafri razajafri added bug Something isn't working ? - Needs Triage Need team to review and classify audit_4.0.0 Audit related tasks for 4.0.0 labels Apr 15, 2024
@razajafri razajafri mentioned this issue Apr 15, 2024
Closed
@razajafri razajafri changed the title uncacheTableOrView changed in CommandUtils [AUDIT] uncacheTableOrView changed in CommandUtils Apr 16, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Apr 16, 2024
@mythrocks mythrocks self-assigned this May 22, 2024
mythrocks added a commit to mythrocks/spark-rapids that referenced this issue May 22, 2024
@mythrocks
Account for CommandUtils.uncacheTableOrView signature change.
41df548 
Fixes NVIDIA#10710.

This commit accounts for the changes in the signature of `CommandUtils.uncacheTableOrView`
in Apache Spark 4.0. (See [SPARK-47191](apache/spark#45289).)

Signed-off-by: MithunR <[email protected]>
@mythrocks mythrocks mentioned this issue May 22, 2024
Merged
razajafri pushed a commit that referenced this issue May 30, 2024
@mythrocks
[Spark 4.0] Account for CommandUtils.uncacheTableOrView signature c…
499a45b 
…hange. (#10863)

* Account for `CommandUtils.uncacheTableOrView` signature change.

Fixes #10710.

This commit accounts for the changes in the signature of `CommandUtils.uncacheTableOrView`
in Apache Spark 4.0. (See [SPARK-47191](apache/spark#45289).)

Signed-off-by: MithunR <[email protected]>

* Removed unnecessary base class.

---------

Signed-off-by: MithunR <[email protected]>
@mythrocks
Copy link
Collaborator

This has been addressed by #10863.

SurajAralihalli pushed a commit to SurajAralihalli/spark-rapids that referenced this issue Jul 12, 2024
@mythrocks @SurajAralihalli
[Spark 4.0] Account for CommandUtils.uncacheTableOrView signature c…
aec7279 
…hange. (NVIDIA#10863)

* Account for `CommandUtils.uncacheTableOrView` signature change.

Fixes NVIDIA#10710.

This commit accounts for the changes in the signature of `CommandUtils.uncacheTableOrView`
in Apache Spark 4.0. (See [SPARK-47191](apache/spark#45289).)

Signed-off-by: MithunR <[email protected]>

* Removed unnecessary base class.

---------

Signed-off-by: MithunR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mythrocks mythrocks

Labels
audit_4.0.0 Audit related tasks for 4.0.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Spark 4.0] Account for CommandUtils.uncacheTableOrView signature change. mythrocks/spark-rapids
3 participants
@mattahrens @mythrocks @razajafri