Skip to content

Commit

Permalink
debug
Browse files Browse the repository at this point in the history
Signed-off-by: Raza Jafri <[email protected]>
  • Loading branch information
razajafri committed Oct 20, 2021
1 parent 7c0b88a commit 7b310e9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,12 @@ public ColumnarBatch next() {
// We are branching over the output.length to know which kernel to call.
// If output.length < 100 we call the fixed-width optimized version, otherwise the
// generic one
Table tab = isOptimizedForFixedWidth ?
Table tab = //isOptimizedForFixedWidth ?
// The fixed-width optimized cudf kernel only supports up to 1.5 KB per row which means
// at most 184 double/long values. We are branching over the output.length to know
// which kernel to call. If output.length < 100 we call the fixed-width optimized
// version, otherwise the generic one
Table.convertFromRowsFixedWidthOptimized(cv, rapidsTypes) :
// Table.convertFromRowsFixedWidthOptimized(cv, rapidsTypes) :
Table.convertFromRows(cv, rapidsTypes)) {
return GpuColumnVector.from(tab, outputTypes);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,10 @@ class AcceleratedColumnarToRowIterator(
// until we have tested it more. We branching over the output.length to know which kernel
// to call. If output.length < 100 we call the fixed-width optimized version, otherwise
// the generic one
withResource(if (isFixedWidthOptimized) {
table.convertToRowsFixedWidthOptimized()
} else {
table.convertToRows()
}) { rowsCvList =>
withResource( // if (isFixedWidthOptimized) {
// table.convertToRowsFixedWidthOptimized()
// } else {
table.convertToRows()) { rowsCvList =>
rowsCvList.foreach { rowsCv =>
pendingCvs += rowsCv.copyToHost()
}
Expand Down Expand Up @@ -350,7 +349,7 @@ object GpuColumnarToRowExecParent {
// We are being conservative by only allowing 100M columns until we feel the need to
// increase this number
output.length <= 100000000) {
(batches: Iterator[ColumnarBatch]) => {
batches: Iterator[ColumnarBatch] => {
// UnsafeProjection is not serializable so do it on the executor side
val toUnsafe = UnsafeProjection.create(output, output)
new AcceleratedColumnarToRowIterator(output, batches, numInputBatches, numOutputRows,
Expand Down

0 comments on commit 7b310e9

Please sign in to comment.