Skip to content

Commit

Permalink
Add temporary logging for Dataproc round robin fallback issue (#2490)
Browse files Browse the repository at this point in the history
Signed-off-by: Jason Lowe <[email protected]>
  • Loading branch information
jlowe authored May 24, 2021
1 parent d631089 commit 1cf741b
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,17 @@ class GpuShuffleMeta(
shuffle.outputPartitioning match {
case _: RoundRobinPartitioning if shuffle.sqlContext.conf.sortBeforeRepartition =>
val orderableTypes = GpuOverrides.pluginSupportedOrderableSig
System.err.println(s"Checking round-robin sort for ${shuffle.output.map(_.dataType)}")
shuffle.output.map(_.dataType)
.filterNot(orderableTypes.isSupportedByPlugin(_, conf.decimalTypeEnabled))
.foreach { dataType =>
System.err.println(s"Disallowing $dataType for round-robin partitioning")
willNotWorkOnGpu(s"round-robin partitioning cannot sort $dataType to run " +
s"this on the GPU set ${SQLConf.SORT_BEFORE_REPARTITION.key} to false")
}
case _: RoundRobinPartitioning =>
System.err.println(s"Allowing ${shuffle.output.map(_.dataType)} for round-robin " +
s"sort-before=${shuffle.sqlContext.conf.sortBeforeRepartition}")
case _ =>
}
}
Expand Down

0 comments on commit 1cf741b

Please sign in to comment.