-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cuml from 23.06 to 23.08 in pytests and ci #353
Conversation
build |
1 similar comment
build |
build |
RUN conda install -y -c conda-forge mamba=1.4.9 libarchive && \ | ||
mamba install -y -c rapidsai -c nvidia -c conda-forge cuml=$CUML_VER python=3.9 cuda-toolkit=11.5 \ | ||
mamba install -y -c rapidsai-nightly -c nvidia -c conda-forge cuml=$CUML_VER python=3.9 cuda-toolkit=11.5 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rapids now use cuda-version
pkg (https://anaconda.org/conda-forge/cuda-version/files) instead of cuda-toolkit to navigate the specific libcudf pkg (these 2 pkgs have diverged about version patterning)
https://github.com/rapidsai/cudf#conda, could try use cuda-version=11.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment! Cuml is still using cuda-toolkit in the release selector: https://docs.rapids.ai/install. Maybe we can stay with cuda-toolkit for now and try to use cuda-version after cuml adopts it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think their page is out of date at least for 23.08 (not-released yet) rapidsai/cuml#5318 rapidsai/cudf#13615
but feel free to update it when needed
build |
Signed-off-by: Jinfeng <[email protected]>
Signed-off-by: Jinfeng <[email protected]>
Signed-off-by: Jinfeng <[email protected]>
build |
Tested in rapids-23.06 locally. run_tests.sh passed. |
Fixed an issue in LinearRegression that adds the copy_X init argument to match cuml 23.08 LinearRegression init argument list.