Document local cross-repo testing for spark-rapids, spark-rapids-jni, and cudf [skip ci] #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <[email protected]>
|
I like the documentation update. I'm not sure the best language is to phrase it with we though like "When we build ...". I'm not overly critical of this though and willing to live with it if it is acceptable for others. Thank you for taking the time to do this. I believe this will help new users acclimate to the process. |
jlowe
reviewed
Jul 15, 2022
Co-authored-by: Jason Lowe <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
changed the title
|
build |
jlowe
reviewed
Jul 20, 2022
Co-authored-by: @jlowe Signed-off-by: Gera Shegalov <[email protected]>
|
build |
jlowe
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents how to test changes in cudf, spark-rapids-jni, and spark-rapids together locally end-to-end.
Signed-off-by: Gera Shegalov [email protected]