Add new native parquet footer API and deprecate the old one #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
revans2
changed the title
andygrove
previously approved these changes
Jul 11, 2022
abellina
reviewed
Jul 11, 2022
| @@ -63,6 +129,83 @@ public void close() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| private static void depthFirstNamesHelper(SchemaElement se, String name, boolean makeLowerCase, | |||
There was a problem hiding this comment.
could a small comment block be added here describing why we need the helper?
| for (ElementWithName child : st.children) { | ||
| depthFirstNamesHelper(child.element, child.name, makeLowerCase, names, numChildren); | ||
| } | ||
| } else if (se instanceof ListElement) { |
There was a problem hiding this comment.
nit,
Suggested change
| } else if (se instanceof ListElement) { | |
| } else if (se instanceof ListElement) { |
jlowe
previously approved these changes
Jul 11, 2022
|
build |
|
@abellina please take another look |
revans2
changed the title
abellina
approved these changes
Jul 11, 2022
jlowe
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new API for parsing and filtering a parquet footer using native code. This will allow us to fix the issues associated with legacy parquet files. It does not fix any of those issues yet. This just adds in the API so we can start to use it without breaking anyone.