Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch spdlog without depending on cudf #2679

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fetch spdlog without depending on cudf #2679

merged 4 commits into from
Dec 11, 2024

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Dec 11, 2024 •
edited
Loading

After rapidsai/cudf#17307, cudf no longer provide spdlog in its dependency chain. As such, we need to adapt to it.

This PR remove the dependency on cudf for fetching spdlog. Instead, spark-rapids-jni will fetch spdlog on its own.

@ttnghia ttnghia added bug Something isn't working tech debt labels Dec 11, 2024
@ttnghia ttnghia requested a review from jlowe December 11, 2024 05:38
@ttnghia ttnghia self-assigned this Dec 11, 2024
@ttnghia ttnghia mentioned this pull request Dec 11, 2024
Merged
3 tasks
jlowe
jlowe reviewed Dec 11, 2024
View reviewed changes
src/main/cpp/faultinj/faultinj.cu Outdated Show resolved Hide resolved
src/main/cpp/src/SparkResourceAdaptorJni.cpp Outdated Show resolved Hide resolved
@ttnghia ttnghia changed the title Replace spdlog by cudf::logger Fetch spdlog without depending on cudf Dec 11, 2024
@ttnghia
Copy link
Collaborator Author

ttnghia commented Dec 11, 2024

build

@ttnghia ttnghia requested a review from jlowe December 11, 2024 18:26
@ttnghia ttnghia merged commit 5231d4d into NVIDIA:branch-25.02 Dec 11, 2024
4 checks passed
@ttnghia ttnghia deleted the fix_logger branch December 11, 2024 19:51
@abellina abellina mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@ttnghia ttnghia

Labels
bug Something isn't working tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttnghia @jlowe