Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field name matching in get_json_object with escaped characters #2410

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Sep 18, 2024

This fixes a bug in the matching code in json_parser.cuh that incorrectly checks for character matching, which results in an incorrect output when the input JSON string contains escaped characters in field names.

Closes #2397.

Note that the opposite case, when the JSON paths contain escaped characters in name instructions is still not supported.

Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia added the bug Something isn't working label Sep 18, 2024
@ttnghia ttnghia requested a review from revans2 September 18, 2024 20:42
@ttnghia ttnghia self-assigned this Sep 18, 2024
@ttnghia
Copy link
Collaborator Author

ttnghia commented Sep 18, 2024

build

@ttnghia ttnghia changed the title Fix field name matching with escaped characters Fix field name matching in get_json_object with escaped characters Sep 19, 2024
@ttnghia ttnghia merged commit 1f69a9a into NVIDIA:branch-24.10 Sep 19, 2024
4 checks passed
@ttnghia ttnghia deleted the fix_match_escaped branch September 19, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] get_json_object cannot match field name with escaped characters
2 participants