-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build link from the pre-merge-CI workflow [skip ci] #1933
Conversation
} else { | ||
// upload log only in case of build failure | ||
def guardWords = ["gitlab.*?\\.com", "urm.*?\\.com"] | ||
guardWords.add("nvidia-smi(?s)(.*?)(?=git)") // hide GPU info | ||
guardWords.add("sc-ipp*") // hide cloud info | ||
githubHelper.uploadLogs(this, env.JOB_NAME, env.BUILD_NUMBER, null, guardWords) | ||
|
||
githubHelper.updateCommitStatus("$BUILD_URL", "Fail", GitHubCommitState.FAILURE) | ||
githubHelper.updateCommitStatus("", "Fail", GitHubCommitState.FAILURE) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the failed build link, are we still linking to the uploaded log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I did not realize it a little diff from spark-rapids log uploading: NVIDIA/spark-rapids#10664 (comment)
Let me double check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build PASS:
FAILED LOG uploaded:
FAILED log uploaded: https://github.com/NVIDIA/spark-rapids-jni/actions/runs/8613010813/job/23603450936
build |
Signed-off-by: Tim Liu <[email protected]>
build |
1 similar comment
build |
convert to draft to check failure log uploading |
build |
2 similar comments
build |
build |
build |
We need to remove all the CI job's link from the pre-merge-CI workflow