Move device code in get_json_object to cu or cuh #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <[email protected]>
res-life
reviewed
Apr 2, 2024
| @@ -23,6 +23,8 @@ public class JSONUtils { | |||
| NativeDepsLoader.loadNativeDeps(); | |||
| } | |||
|
|
|||
| public static final int MAX_PATH_DEPTH = 32; | |||
There was a problem hiding this comment.
I did not find any usage for this new variable.
There was a problem hiding this comment.
It will be used in plugin, for max path instructions fallback.
res-life
previously approved these changes
Apr 2, 2024
|
build |
|
build |
res-life
approved these changes
Apr 2, 2024
res-life
pushed a commit
to res-life/spark-rapids-jni
that referenced
this pull request
Apr 7, 2024
Signed-off-by: Haoyang Li <[email protected]>
res-life
pushed a commit
to res-life/spark-rapids-jni
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Haoyang Li <[email protected]>
res-life
added a commit
that referenced
this pull request
Apr 11, 2024
…1930) * Move device code in get_json_object to cu or cuh (#1915) Signed-off-by: Haoyang Li <[email protected]> * Refactor/simplify json generator Signed-off-by: Chong Gao <[email protected]> * Remove purge non-empty nulls step * Refactor josn parser: remove useless variables * Use 64 bits to store JSON nest depth context to save memory * Refine push/pop/peek logic * Refactor: use less functions; change max path length from 32 to 8 * Fix nvbug: get-json-obj get incorrect result on some GPUs(H100, V100) * Revert "Fix nvbug: get-json-obj get incorrect result on some GPUs(H100, V100)" This reverts commit ff2db7e. * Fix a redefined variable * Update MAX_PATH_DEPTH = 8 in Java to keep consistent * Fix test cases; Change max path depth from 8 to 16 * Minor change: add pragma once in header --------- Signed-off-by: Haoyang Li <[email protected]> Signed-off-by: Chong Gao <[email protected]> Co-authored-by: Haoyang Li <[email protected]> Co-authored-by: Chong Gao <[email protected]>
thirtiseven
added a commit
that referenced
this pull request
Apr 11, 2024
* Move device code in get_json_object to cu or cuh (#1915) Signed-off-by: Haoyang Li <[email protected]> * Refactor/simplify json generator Signed-off-by: Chong Gao <[email protected]> * Remove purge non-empty nulls step * Refactor josn parser: remove useless variables * Use 64 bits to store JSON nest depth context to save memory * Refine push/pop/peek logic * Refactor: use less functions; change max path length from 32 to 8 * Fix nvbug: get-json-obj get incorrect result on some GPUs(H100, V100) * Revert "Fix nvbug: get-json-obj get incorrect result on some GPUs(H100, V100)" This reverts commit ff2db7e. * Fix a redefined variable * Update MAX_PATH_DEPTH = 8 in Java to keep consistent * Fix test cases; Change max path depth from 8 to 16 * Minor change: add pragma once in header * Fix a bug in string_to_float and move it to jni temporarily Signed-off-by: Haoyang Li <[email protected]> * Address comments Signed-off-by: Haoyang Li <[email protected]> --------- Signed-off-by: Haoyang Li <[email protected]> Signed-off-by: Chong Gao <[email protected]> Co-authored-by: Chong Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1906
This PR:
I think we can make this moving code change first so it will be easy to review when addressing other comments.