Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[submodule-sync] bot-submodule-sync-branch-24.02 to branch-24.02 [skip ci] [bot]" #1828

Merged

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Mar 5, 2024

Reverts #1821

Sorry this is my mistake.

I was trying my auto-release test script, but mistakenly merged a fake cudf v24.04.00a tag into the NVIDIA/spark-rapids-jni
(I intended to merge it into nvtimliu/spark-rapids-jni, but OWNER=${OWNER:-NVTIMLIU} was overwritten by test CI environment)

Then nvauto treaded this PR as a common cudf-submodule update one, and got it merged directly.

I've deleted my test CI job to prevent this problem from happening again.

Signed-off-by: Tim Liu [email protected]

@NvTimLiu NvTimLiu self-assigned this Mar 5, 2024
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Mar 5, 2024

build

@GaryShen2008
Copy link
Collaborator

GaryShen2008 commented Mar 5, 2024

@NvTimLiu Please check if branch-24.04 has been impacted.

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Mar 5, 2024

@NvTimLiu Please check if branch-24.04 has been impacted.

Though it was auto-merged into branch-24.04, but cudf-submodule is always been updated to cudf branch-24.04 immediately.

So for cudf-submodule on branch-24.04, no impact.

For the submodule-sync.sh, the change was also to branch-24.04, it's works on branch-24.04, and will be restored after this revert PR get merged.

@GaryShen2008 GaryShen2008 merged commit f1e37af into branch-24.02 Mar 5, 2024
3 of 4 checks passed
@nvauto nvauto deleted the revert-1821-bot-submodule-sync-branch-24.02 branch March 8, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants