Upmerge to the latest CUDF and fix compile errors #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
jlowe
reviewed
May 19, 2023
|
Just FYI there was a breaking change made in some of the CUDF java code that I will also put up a patch in the plugin to fix. |
|
build |
|
NVIDIA/spark-rapids#8328 will fix the issues in the plugin. I am going to run more tests still. I mostly just got it to compile before putting up the PR... |
|
build |
|
Ran our jni tests, things seem ok from that perspective. |
jlowe
previously approved these changes
May 19, 2023
|
oops didn't fix the test code :( doing that now... |
|
build |
jlowe
approved these changes
May 19, 2023
abellina
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upmerges to the latest 23.06 CUDF and fixes the compile errors in our code that showed up with it.
I will be testing this on our plugin too, but I wanted to get this up and started to unblock people.