Ensure columns have valid null counts. #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in prep for rapidsai/cudf#11968 and rapidsai/cudf#13372. `libcudf` will soon require that all CUDF columns are created with a known null-count. `UNKNOWN_NULL_COUNT` will no longer be supported, or even available as a code constant. This change replicates part of rapidsai/cudf#13355, as it applies to `row_conversion.cu`. The (single) reference to the unknown-null-count is replaced with a pre-calculated value. Signed-off-by: MithunR <[email protected]>
|
Build |
revans2
approved these changes
May 18, 2023
|
Thank you for reviewing, @revans2. I have merged this change. |
mythrocks
added a commit
to mythrocks/spark-rapids-jni
that referenced
this pull request
May 19, 2023
This is a followup to NVIDIA#1148. `row_conversion.cu` was modified in rapidsai/cudf#13372 to explicitly calculate null-counts for output columns. This commit replicates the changes in cudf/pull/13372, and adds explicit null-count calculation for the string offsets column. Signed-off-by: MithunR <[email protected]>
mythrocks
added a commit
to mythrocks/spark-rapids-jni
that referenced
this pull request
May 22, 2023
This is a followup to NVIDIA#1148. `row_conversion.cu` was modified in rapidsai/cudf#13372 to explicitly calculate null-counts for output columns. This commit replicates the changes in cudf/pull/13372, and adds explicit null-count calculation for the string offsets column. Signed-off-by: MithunR <[email protected]>
mythrocks
added a commit
that referenced
this pull request
May 23, 2023
* Followup for null count fixup in row_conversion.cu. This is a followup to #1148. `row_conversion.cu` was modified in rapidsai/cudf#13372 to explicitly calculate null-counts for output columns. This commit replicates the changes in cudf/pull/13372, and adds explicit null-count calculation for the string offsets column. Signed-off-by: MithunR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in prep for rapidsai/cudf#11968 and rapidsai/cudf#13372.
libcudfwill soon require that all CUDF columns are created with a known null-count.UNKNOWN_NULL_COUNTwill no longer be supported, or even available as a code constant.This change replicates part of rapidsai/cudf#13355, as it applies to
row_conversion.cu. The (single) reference to the unknown-null-count is replaced with a pre-calculated value.