Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with CUDA 12 #1143

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix build with CUDA 12 #1143

merged 2 commits into from
May 17, 2023

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented May 16, 2023

This fixes CMake to install libcudacxx and thrust, allowing spark-rapids-jni to use the same libraries as used to build libcudf. This also temporarily fixes the build issue with CUDA 12.

Closes #1136.

@ttnghia ttnghia added the bug Something isn't working label May 16, 2023
@ttnghia ttnghia self-assigned this May 16, 2023
@ttnghia
Copy link
Collaborator Author

ttnghia commented May 16, 2023

With this fix, spark-rapids-jni was successfully built with cuda-12.1.1 docker image.

@ttnghia
Copy link
Collaborator Author

ttnghia commented May 16, 2023

@pxLi Can you help verify this please?

@ttnghia ttnghia requested a review from pxLi May 16, 2023 17:22
src/main/cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@jlowe
Copy link
Member

jlowe commented May 16, 2023

build

@pxLi
Copy link
Collaborator

pxLi commented May 17, 2023

@pxLi Can you help verify this please?

thanks! I am verifying CI internally and will merge this if cuda12 build and test passed

@pxLi pxLi merged commit 2d9d004 into NVIDIA:branch-23.06 May 17, 2023
@ttnghia ttnghia deleted the fix_cuda_12_build branch June 9, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] build failed on cuda 12 runtime
3 participants