Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[submodule-sync] bot-submodule-sync-branch-23.06 to branch-23.06 [skip ci] [bot] #1080

Closed
wants to merge 4 commits into from
Closed

[submodule-sync] bot-submodule-sync-branch-23.06 to branch-23.06 [skip ci] [bot] #1080

wants to merge 4 commits into from

Conversation

nvauto
Copy link
Collaborator

@nvauto nvauto commented Apr 15, 2023

submodule-sync to create a PR keeping thirdparty/cudf up-to-date.
HEAD commit SHA: b55db80, cudf commit SHA: rapidsai/cudf@daf3ac0

This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix.

@nvauto
Copy link
Collaborator Author

nvauto commented Apr 15, 2023

HEAD commit SHA: b55db80, CUDF commit SHA: rapidsai/cudf@daf3ac0
Test passed: False

@nvauto
Copy link
Collaborator Author

nvauto commented Apr 15, 2023

HEAD commit SHA: b821b34, CUDF commit SHA: rapidsai/cudf@0b59fda
Test passed: False

3 similar comments
@nvauto
Copy link
Collaborator Author

nvauto commented Apr 15, 2023

HEAD commit SHA: b821b34, CUDF commit SHA: rapidsai/cudf@0b59fda
Test passed: False

@nvauto
Copy link
Collaborator Author

nvauto commented Apr 15, 2023

HEAD commit SHA: b821b34, CUDF commit SHA: rapidsai/cudf@0b59fda
Test passed: False

@nvauto
Copy link
Collaborator Author

nvauto commented Apr 15, 2023

HEAD commit SHA: b821b34, CUDF commit SHA: rapidsai/cudf@0b59fda
Test passed: False

@nvauto
Copy link
Collaborator Author

nvauto commented Apr 16, 2023

HEAD commit SHA: 8f33e72, CUDF commit SHA: rapidsai/cudf@580ee40
Test passed: False

@pxLi
Copy link
Collaborator

pxLi commented Apr 17, 2023 

11:12:45  [INFO]      [exec] [ 91%] Built target cufilejni
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp: In member function 'virtual void StringToFloatTests_Simple_Test<gtest_TypeParam_>::TestBody()':
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp:578:26: error: no matching function for call to 'cudf::column::set_null_mask(std::pair<rmm::device_buffer, int>)'
11:12:45  [INFO]      [exec]   578 |   expected->set_null_mask(
11:12:45  [INFO]      [exec]       |   ~~~~~~~~~~~~~~~~~~~~~~~^
11:12:45  [INFO]      [exec]   579 |     cudf::test::detail::make_null_mask(valid_iter, valid_iter + expected->size()));
11:12:45  [INFO]      [exec]       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:12:45  [INFO]      [exec] In file included from /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf_test/column_wrapper.hpp:19,
11:12:45  [INFO]      [exec]                  from /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp:20:
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:194:8: note: candidate: 'void cudf::column::set_null_mask(rmm::device_buffer&&, cudf::size_type)'
11:12:45  [INFO]      [exec]   194 |   void set_null_mask(rmm::device_buffer&& new_null_mask,
11:12:45  [INFO]      [exec]       |        ^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:194:43: note:   no known conversion for argument 1 from 'std::pair<rmm::device_buffer, int>' to 'rmm::device_buffer&&'
11:12:45  [INFO]      [exec]   194 |   void set_null_mask(rmm::device_buffer&& new_null_mask,
11:12:45  [INFO]      [exec]       |                      ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:212:8: note: candidate: 'void cudf::column::set_null_mask(const rmm::device_buffer&, cudf::size_type, rmm::cuda_stream_view)'
11:12:45  [INFO]      [exec]   212 |   void set_null_mask(rmm::device_buffer const& new_null_mask,
11:12:45  [INFO]      [exec]       |        ^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:212:48: note:   no known conversion for argument 1 from 'std::pair<rmm::device_buffer, int>' to 'const rmm::device_buffer&'
11:12:45  [INFO]      [exec]   212 |   void set_null_mask(rmm::device_buffer const& new_null_mask,
11:12:45  [INFO]      [exec]       |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp: In member function 'virtual void StringToFloatTests_InfNaN_Test<gtest_TypeParam_>::TestBody()':
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp:595:26: error: no matching function for call to 'cudf::column::set_null_mask(std::pair<rmm::device_buffer, int>)'
11:12:45  [INFO]      [exec]   595 |   expected->set_null_mask(
11:12:45  [INFO]      [exec]       |   ~~~~~~~~~~~~~~~~~~~~~~~^
11:12:45  [INFO]      [exec]   596 |     cudf::test::detail::make_null_mask(valid_iter, valid_iter + expected->size()));
11:12:45  [INFO]      [exec]       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:12:45  [INFO]      [exec] In file included from /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf_test/column_wrapper.hpp:19,
11:12:45  [INFO]      [exec]                  from /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp:20:
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:194:8: note: candidate: 'void cudf::column::set_null_mask(rmm::device_buffer&&, cudf::size_type)'
11:12:45  [INFO]      [exec]   194 |   void set_null_mask(rmm::device_buffer&& new_null_mask,
11:12:45  [INFO]      [exec]       |        ^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:194:43: note:   no known conversion for argument 1 from 'std::pair<rmm::device_buffer, int>' to 'rmm::device_buffer&&'
11:12:45  [INFO]      [exec]   194 |   void set_null_mask(rmm::device_buffer&& new_null_mask,
11:12:45  [INFO]      [exec]       |                      ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:212:8: note: candidate: 'void cudf::column::set_null_mask(const rmm::device_buffer&, cudf::size_type, rmm::cuda_stream_view)'
11:12:45  [INFO]      [exec]   212 |   void set_null_mask(rmm::device_buffer const& new_null_mask,
11:12:45  [INFO]      [exec]       |        ^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:212:48: note:   no known conversion for argument 1 from 'std::pair<rmm::device_buffer, int>' to 'const rmm::device_buffer&'
11:12:45  [INFO]      [exec]   212 |   void set_null_mask(rmm::device_buffer const& new_null_mask,
11:12:45  [INFO]      [exec]       |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp: In member function 'virtual void StringToFloatTests_InvalidValues_Test<gtest_TypeParam_>::TestBody()':
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp:612:26: error: no matching function for call to 'cudf::column::set_null_mask(std::pair<rmm::device_buffer, int>)'
11:12:45  [INFO]      [exec]   612 |   expected->set_null_mask(
11:12:45  [INFO]      [exec]       |   ~~~~~~~~~~~~~~~~~~~~~~~^
11:12:45  [INFO]      [exec]   613 |     cudf::test::detail::make_null_mask(valid_iter, valid_iter + expected->size()));
11:12:45  [INFO]      [exec]       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:12:45  [INFO]      [exec] In file included from /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf_test/column_wrapper.hpp:19,
11:12:45  [INFO]      [exec]                  from /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/src/main/cpp/tests/cast_string.cpp:20:
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:194:8: note: candidate: 'void cudf::column::set_null_mask(rmm::device_buffer&&, cudf::size_type)'
11:12:45  [INFO]      [exec]   194 |   void set_null_mask(rmm::device_buffer&& new_null_mask,
11:12:45  [INFO]      [exec]       |        ^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:194:43: note:   no known conversion for argument 1 from 'std::pair<rmm::device_buffer, int>' to 'rmm::device_buffer&&'
11:12:45  [INFO]      [exec]   194 |   void set_null_mask(rmm::device_buffer&& new_null_mask,
11:12:45  [INFO]      [exec]       |                      ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:212:8: note: candidate: 'void cudf::column::set_null_mask(const rmm::device_buffer&, cudf::size_type, rmm::cuda_stream_view)'
11:12:45  [INFO]      [exec]   212 |   void set_null_mask(rmm::device_buffer const& new_null_mask,
11:12:45  [INFO]      [exec]       |        ^~~~~~~~~~~~~
11:12:45  [INFO]      [exec] /home/jenkins/agent/workspace/spark-rapids-jni_submodule-sync-dev/target/libcudf-install/include/cudf/column/column.hpp:212:48: note:   no known conversion for argument 1 from 'std::pair<rmm::device_buffer, int>' to 'const rmm::device_buffer&'
11:12:45  [INFO]      [exec]   212 |   void set_null_mask(rmm::device_buffer const& new_null_mask,
11:12:45  [INFO]      [exec]       |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
11:12:50  [INFO]      [exec] gmake[2]: *** [tests/CMakeFiles/CAST_STRING.dir/build.make:76: tests/CMakeFiles/CAST_STRING.dir/cast_string.cpp.o] Error 1
11:12:50  [INFO]      [exec] gmake[1]: *** [CMakeFiles/Makefile2:976: tests/CMakeFiles/CAST_STRING.dir/all] Error 2
11:12:50  [INFO]      [exec] gmake[1]: *** Waiting for unfinished jobs....
11:13:05  [INFO]      [exec] [ 95%] Linking CXX executable ../gtests/ROW_CONVERSION
11:13:06  [INFO]      [exec] [ 95%] Built target ROW_CONVERSION
11:13:06  [INFO]      [exec] gmake: *** [Makefile:146: all] Error 2
11:13:06  [INFO] ------------------------------------------------------------------------
11:13:06  [INFO] BUILD FAILURE

@nvauto
Copy link
Collaborator Author

nvauto commented Apr 17, 2023

HEAD commit SHA: 6bd4704, CUDF commit SHA: rapidsai/cudf@a6fb6a2
Test passed: False

1 similar comment
@nvauto
Copy link
Collaborator Author

nvauto commented Apr 17, 2023

HEAD commit SHA: 6bd4704, CUDF commit SHA: rapidsai/cudf@a6fb6a2
Test passed: False

@jlowe
Copy link
Member

jlowe commented Apr 17, 2023

make_null_mask return value was changed in rapidsai/cudf#13081, need to update our test code accordingly.

@jlowe jlowe mentioned this pull request Apr 17, 2023
Merged
@jlowe
Copy link
Member

jlowe commented Apr 17, 2023

Will be fixed by #1081.

@nvauto
Copy link
Collaborator Author

nvauto commented Apr 17, 2023

HEAD commit SHA: 6bd4704, CUDF commit SHA: rapidsai/cudf@a6fb6a2
Test passed: False

@jlowe jlowe closed this Apr 17, 2023
@nvauto nvauto deleted the bot-submodule-sync-branch-23.06 branch April 17, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvauto @pxLi @jlowe