Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile should derive from cudf Java Dockerfile #203

Open
jlowe opened this issue Apr 26, 2022 · 7 comments
Open

Dockerfile should derive from cudf Java Dockerfile #203

jlowe opened this issue Apr 26, 2022 · 7 comments
Labels

Comments

@jlowe
Copy link
Member

jlowe commented Apr 26, 2022

Since this project builds libcudf and libcudfjni, ideally the Dockerfile used for this project should derive from the Dockerfile used for the nightly cudf Java jar builds. Doing so would require publishing the cudf Java Docker image so it can be referenced in this repository's Dockerfile.

@GaryShen2008
Copy link
Collaborator

Where should we publish the cudf java docker? dockerhub? quay.io?

@jlowe
Copy link
Member Author

jlowe commented Apr 29, 2022

It may make the most sense to publish it under dockerhub/gpuci since the Java Dockerfile is part of the cudf project and other RAPIDS images are published there. If that's not an option, I don't have a strong opinion on where to publish it as long as it is publicly accessible for this project. cc: @sameerz for visibility.

@sameerz
Copy link
Collaborator

sameerz commented Apr 29, 2022

dockerhub/gpuci seems like the right place to publish the cudf Java jar builds.

cc: @raydouglass for visibility

rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue May 10, 2022
Signed-off-by: Peixin Li <[email protected]>

related to NVIDIA/spark-rapids-jni#203

I don't know if any restriction of using github actions in rapids org, 
so this PR is just a prototype and waiting for feedback :)

Example in my forked repo,
1. Manual trigger the build
![image](https://user-images.githubusercontent.com/8086184/167101308-b3e4376e-4c42-4603-aca1-2b0f40ace16f.png)
2. example logs https://github.com/pxLi/cudf/runs/6319840419?check_suite_focus=true
3. pushed images https://hub.docker.com/r/pxli/cudf-jni-build/tags
![image](https://user-images.githubusercontent.com/8086184/167102403-a5b49a99-d8de-46d6-b5df-a1ea50254448.png)


Some open questions:
1. Trigger strategy? Manual, crontab, merge trigger, or others?
2. which org in docker hub should we push the image to? gpuci?
3. which account we should use to push?
4. do we want to keep the commit tags or we just overwrite the branch-XY tag only? mostly about space :)

Thanks!

Authors:
  - Peixin (https://github.com/pxLi)

Approvers:
  - Jason Lowe (https://github.com/jlowe)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #10806
@pxLi
Copy link
Collaborator

pxLi commented May 10, 2022

follow-up to figure out a good way to support auto-trigger in cudf repo w/o cost too much

@pxLi
Copy link
Collaborator

pxLi commented May 10, 2022

@jlowe
Copy link
Member Author

jlowe commented May 11, 2022

follow-up to figure out a good way to support auto-trigger in cudf repo w/o cost too much

I'm confused why this repository would track an issue with the cudf repository. The Dockerfile in question is in cudf, and ideally changes to that Dockerfile should trigger a rebuild and push of the new image to the Docker repository, possibly with a workflow action in the cudf repository. It feels odd to "fix" that problem in this repository, especially since it's not in the rapidsai domain.

Also fixing this particular issue, where we base the spark-rapids-jni Dockerfile on the published cudf Dockerfile, is somewhat orthogonal. We can get one working without the other, and thus they should be handled as separate issues.

@pxLi
Copy link
Collaborator

pxLi commented May 12, 2022

follow-up to figure out a good way to support auto-trigger in cudf repo w/o cost too much

I'm confused why this repository would track an issue with the cudf repository. The Dockerfile in question is in cudf, and ideally changes to that Dockerfile should trigger a rebuild and push of the new image to the Docker repository, possibly with a workflow action in the cudf repository. It feels odd to "fix" that problem in this repository, especially since it's not in the rapidsai domain.

Also fixing this particular issue, where we base the spark-rapids-jni Dockerfile on the published cudf Dockerfile, is somewhat orthogonal. We can get one working without the other, and thus they should be handled as separate issues.

Since the requirement of cudfjni build image of rapidsai is originally coming from this one, I would put the context here as a reminder. Potentially we could use a workaround like scan cudf commits in this github action of this repo, if found related dockerfile changes from upstream submodule, then notify us to do manual trigger.

This is more about we have less access of rapidsai repo. It would be not that easy for us to make changes or debugging stuff by leveraging their CICD resources in the future. And yes, I totally agree this should be a separate issue in cudf repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants