Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Hash was removed from cudf, but it is still referenced in spark-rapids-jni tests #1926

Closed
hyperbolic2346 opened this issue Apr 5, 2024 · 1 comment
Closed

[BUG] Hash was removed from cudf, but it is still referenced in spark-rapids-jni tests #1926

hyperbolic2346 opened this issue Apr 5, 2024 · 1 comment
Assignees
@gerashegalov
Labels
bug Something isn't working

Comments

@hyperbolic2346
Copy link
Collaborator

hyperbolic2346 commented Apr 5, 2024 •
edited
Loading

Describe the bug
cuDF removed the hash function with this PR. The hash tests in hash.cpp reference this function and are causing compilation errors if compiled against the latest cudf.
@hyperbolic2346 hyperbolic2346 added bug Something isn't working ? - Needs Triage labels Apr 5, 2024
@gerashegalov gerashegalov self-assigned this Apr 5, 2024
@gerashegalov gerashegalov mentioned this issue Apr 6, 2024
Merged
gerashegalov added a commit that referenced this issue Apr 8, 2024
@gerashegalov
Remove tests of deleted cudf::hash HASH_MURMUR3 (#1929)
ffe0f3a 
- Removes tests for the default `cudf::hash`
- Updates cudf deps pins to workaround the issue being fixed by #1928 

Testing:

```bash
$ cd thirdparty/cudf
$ git checkout branch-24.06
$ cd -
$ ./build/build-in-docker clean install -DGPU_ARCHS='NATIVE' -DBUILD_TESTS=0N -DskipTests -Dlibcudf.clean.skip=false -Dlibcudf.dependency.mode=latest -Dsubmodule.check.skip 
$ ./target/cmake-build/gtests/HASH
```

Fixes #1926 
    
Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov
Copy link
Collaborator

fixed by #1929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gerashegalov @hyperbolic2346