Skip to content

Commit

Permalink
Rename MAX_NESTED_DEPTH to MAX_STACK_DEPTH
Browse files Browse the repository at this point in the history
Signed-off-by: Yan Feng <[email protected]>
  • Loading branch information
ustcfy committed Dec 12, 2024
1 parent 70cc8dd commit 3a40c40
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/main/cpp/src/HashJni.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@

extern "C" {

JNIEXPORT jint JNICALL Java_com_nvidia_spark_rapids_jni_Hash_getMaxNestedDepth(JNIEnv* env, jclass)
JNIEXPORT jint JNICALL Java_com_nvidia_spark_rapids_jni_Hash_getMaxStackDepth(JNIEnv* env, jclass)
{
return spark_rapids_jni::MAX_NESTED_DEPTH;
return spark_rapids_jni::MAX_STACK_DEPTH;
}

JNIEXPORT jlong JNICALL Java_com_nvidia_spark_rapids_jni_Hash_murmurHash32(
Expand Down
2 changes: 1 addition & 1 deletion src/main/cpp/src/hash.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
namespace spark_rapids_jni {

constexpr int64_t DEFAULT_XXHASH64_SEED = 42;
constexpr int MAX_NESTED_DEPTH = 8;
constexpr int MAX_STACK_DEPTH = 8;

/**
* @brief Computes the murmur32 hash value of each row in the input set of columns.
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/nvidia/spark/rapids/jni/Hash.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class Hash {
// there doesn't appear to be a useful constant in spark to reference. this could break.
static final long DEFAULT_XXHASH64_SEED = 42;

public static final int MAX_NESTED_DEPTH = getMaxNestedDepth();
public static final int MAX_STACK_DEPTH = getMaxStackDepth();

static {
NativeDepsLoader.loadNativeDeps();
Expand Down Expand Up @@ -102,7 +102,7 @@ public static ColumnVector hiveHash(ColumnView columns[]) {
return new ColumnVector(hiveHash(columnViews));
}

private static native int getMaxNestedDepth();
private static native int getMaxStackDepth();

private static native long murmurHash32(int seed, long[] viewHandles) throws CudfException;

Expand Down

0 comments on commit 3a40c40

Please sign in to comment.