make conda recipe data-loading stricter #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
msarahan
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#72.
Similar to rapidsai/pynvjitlink#90, proposes replacing a use of
.get()in the conda recipe with[], to ensure that we get a loud build error if the"project"table is not present whenconda-buildreadspyproject.toml.Notes for Reviewers
I know that at some time in the past, the
.get()was introduced as a possible solution for errors observed at build time: rapidsai/pynvjitlink#33 (comment)But based on testing over in rapidsai/pynvjitlink#90, that seems to no longer be an issue.