Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use
pynvjitlink
for MVC #23Use
pynvjitlink
for MVC #23Changes from 18 commits
521be20
0f9bc4a
b25db1f
1c3517f
cbcbbab
4406809
dc887b6
7d17759
b9898ec
60d4ca7
db32cfa
bc424ae
56db9c8
c57053c
363b86d
32164e9
c3b9084
2c940ee
a8c38b6
421fdfb
16314a7
41d85a9
f7939b6
91f06a8
0541dcf
710f8cb
a8cb6c2
b8b671f
7c384a3
6327ec2
c97767c
aa3aaf7
f01c0d6
f512bed
15e16a6
519f0c1
1201f1f
883d817
f41b931
e5aa41e
a0ea97d
b979054
beb3301
3f5a865
4770c40
2820ee6
dc20cce
ff18c5c
b2f4245
f40d3ed
c24ec67
dccd6db
9aaa21f
d3ca53c
4ce95a7
d65f80d
5097bcf
e29744c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we missing a bit of logic for handling
.ltoir
here? Or has it gone somewhere else? The original I'm looking at is https://github.com/rapidsai/pynvjitlink/blob/a2f23b7c3c237f2cdde3093c845e0453572503eb/pynvjitlink/patch.py#L170-L171There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise now the handling for this is taken care of by having LTOIR in the file extension map. See comments below (I'll have to link after posting the review because the links don't exist before I post the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment links:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed whilst looking at #48 I think this is superfluous because pynvjitlink sets it itself when you get the linked cubin: https://github.com/rapidsai/pynvjitlink/blob/main/pynvjitlink/api.py#L85