This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Do not move arrival_token in barrier::try_wait #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take a mutable reference instead. Moving the token into try_wait makes no sense. The caller has to be able to retry the try wait with the same token. For more details and C++ spec, see: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2643r1.html
|
Hi @ahendriksen Could you please reopen the PR against our new monorepo https://github.com/NVIDIA/cccl |
|
I have moved the PR to NVIDIA/cccl#283 What is the status of this repository? Are some or all pull requests redirected to cccl? I thought I might have overlooked some documentation, but the contributing guide tells me to open a PR? |
The status is the unfortunate "in transition" We are almost done setting everything up with cccl, so that this repo will be archived afaik |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a mutable reference instead.
Moving the token into try_wait makes no sense. The caller has to be able to retry the try wait with the same token.
For more details and C++ spec, see:
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2643r1.html