This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Invoke result extended lambdas support #284
Merged
wmaxey
merged 2 commits into
NVIDIA:main
from
gevtushenko:enh-main/github/invoke_result_ext_lambdas
Jun 21, 2022
Merged
Invoke result extended lambdas support #284
wmaxey
merged 2 commits into
NVIDIA:main
from
gevtushenko:enh-main/github/invoke_result_ext_lambdas
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not that I'm aware of. @griwes or @wmaxey may know better than me. Adding the |
jrhemstad
reviewed
Jun 13, 2022
jrhemstad
reviewed
Jun 13, 2022
.upstream-tests/test/std/utilities/meta/meta.trans/meta.trans.other/result_of.fail.cpp
Show resolved
Hide resolved
465e6c4
to
941c3cc
Compare
jrhemstad
reviewed
Jun 13, 2022
941c3cc
to
6101e39
Compare
jrhemstad
reviewed
Jun 16, 2022
6101e39
to
a243b84
Compare
wmaxey
reviewed
Jun 17, 2022
.upstream-tests/test/std/utilities/meta/meta.trans/meta.trans.other/result_of.fail.cpp
Outdated
Show resolved
Hide resolved
wmaxey
reviewed
Jun 17, 2022
a243b84
to
c7bd640
Compare
c7bd640
to
1cfa273
Compare
wmaxey
approved these changes
Jun 21, 2022
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue. The implementation of
result_of
andinvoke_result
was complimented with a static assert omitted in device code or compilers different than nvcc. In order not to force users to rewrite device lambdas as function objects,cuda::proclaim_return_type
was added. Since the main use case forcuda::proclaim_return_type
is device lambdas (which type is unknown in any way) I decided to hide the actual wrapper type in detailed namespace.Questions:
docs/serve
failed to start locally without addinggem "webrick"
dependency. I'm not sure if this has to be merged.