This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Disable __builtin_is_constant_evaluated with NVCC in C++11 mode #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
force-pushed
the
bugfix/clang_type_traits_constexpr_non-constant
branch
from
fae861b
to
06a3622
Compare
brycelelbach
approved these changes
Oct 2, 2020
libcxx/include/__config
Outdated
| #if __cplusplus < 201402L | ||
| #undef _LIBCUDACXX_IS_CONSTANT_EVALUATED | ||
| #endif | ||
| #endif |
There was a problem hiding this comment.
Can we do this without an #undef by moving it into the NVCC configuration section, and only defining _LIBCUDACXX_IS_CONSTANT_EVALUATED if not Clang 9 and not C++11?
There was a problem hiding this comment.
Also I'm confused, does this affect GCC too? If so we should have the comment say that. The test indicates it affects GCC 9 and 10 and Clang 9 and 10?
brycelelbach
force-pushed
the
bugfix/clang_type_traits_constexpr_non-constant
branch
from
06a3622
to
aed10ad
Compare
brycelelbach
changed the title
brycelelbach
force-pushed
the
bugfix/clang_type_traits_constexpr_non-constant
branch
from
aed10ad
to
2b08299
Compare
griwes
approved these changes
Oct 2, 2020
…st may need to be moved.
brycelelbach
force-pushed
the
bugfix/clang_type_traits_constexpr_non-constant
branch
from
2b08299
to
d098a95
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVCC reports that uses of
__builtin_is_constant_evaluatedin a constexpr evaluation are invalid:detail/libcxx/include/type_traits(4835): error #2416-D: constexpr function return is non-constantThe fix for now is a WAR that removes the use of the builtin when compiling under NVCC:
I've added a test that should let us know when it's functioning again.