This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix GCC/Clang only compilation of <cuda/std/atomic> #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host form of fetch_min/max
wmaxey
added
testing: internal ci in progress
griwes
approved these changes
Sep 24, 2021
| @@ -0,0 +1,41 @@ | |||
| #ifndef __ATOMIC_BLOCK | |||
There was a problem hiding this comment.
I wonder if this name or something like atomic_scopes.h is better. We only expose these in the cuda:: versions of the interface, true, but it's used throughout...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC and Clang are unable to process
<cuda/std/atomic>as it does not introduce the concept ofScopesinto thecuda::std::namespace.When compiling without the NVCC driver a somewhat half-baked libcxx implementation is instead created. This is fixed by adding a macro to inform the implementation that the scopes need to be injected, while not including the rest of the CUDA mechanics.
MSVC has other issues so this fix is currently specific for GCC/Clang.