This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Documentation changes for wait_parity/try_wait_parity #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
force-pushed
the
docs/barrier-parity
branch
from
c18427d
to
219c1d9
Compare
Merged
gonzalobg
reviewed
Aug 30, 2021
| __global__ void example_kernel(cuda::barrier<cuda::thread_scope_block>& bar) { | ||
| bar.wait_parity(false); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
It would be good to have an example that shows how to use these APIs to accomplish something minimally useful.
It might not be clear to the user what these APIs are for, what the parity of the barrier is initially, how to get the parity of a phase, etc.
gonzalobg
reviewed
Mar 7, 2022
| __host__ __device__ bool cuda::std::barrier::try_wait_parity(bool phase); | ||
| ``` | ||
|
|
||
| `barrier::wait_parity` stalls execution while the barrier is not at the specified parity. |
There was a problem hiding this comment.
We should swap it to match atomic wait. Also make sense as we are waiting for phase to change
|
@wmaxey is this still relevant? Are these APIs still around? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.