Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add clang-11 docker configurations #115

Closed
wants to merge 1 commit into from
Closed

Conversation

veictry
Copy link
Contributor

@veictry veictry commented Feb 9, 2021

Based on nvbug https://nvbugs/200700358

added the required docker configuration related to the build with Clang-11

The image is based on Ubuntu 20.04.
In addition, we define DEBIAN_FRONTEND and TZ in docker layer.

@brycelelbach brycelelbach added this to the 1.4.1 milestone Feb 11, 2021
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files have DOS line endings, please convert to Unix line endings.

Also, I tried running this with a compiler from the dev branch from today and it still says that clang 11 isn't a supported host compiler...

@@ -0,0 +1,109 @@
# Dockerfile for libcudacxx_base:host_x86_64_ubuntu_20.04__target_x86_64_ubuntu_20.04__clang_10_cxx_11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comments to refer to Clang 11 and not 10. (Same for the other files.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@griwes
Thanks Michal!
I'll modify them right now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@griwes
Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the converting from DOS line endings to Unix line endings, I'll try to fix it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done the last task. (submitted by my own Github account)

@griwes
Copy link
Collaborator

griwes commented Feb 23, 2021

Actually ignore the compiler comment, seems my dev environment wasn't completely built, works after applying dos2unix. The rest of the comments stand.

@griwes
Copy link
Collaborator

griwes commented Feb 25, 2021

The variant_configuration.bash files still have windows line endings. Can you fix that and squash all the commits into a single one?

@veictry
Copy link
Contributor Author

veictry commented Feb 25, 2021

The variant_configuration.bash files still have windows line endings. Can you fix that and squash all the commits into a single one?

The line ending issue has been fixed and the commit is modified.
Hi @griwes
Please help to check it again. Thanks!

@veictry
Copy link
Contributor Author

veictry commented Feb 25, 2021

All windows line ending were changed to unix line ending

chengjiew@chengjiew-nvidia:ubuntu_20.04$ git reset --hard
HEAD is now at 6000513 add clang-11 docker configurations
chengjiew@chengjiew-nvidia:ubuntu_20.04$ grep -lR $'\r'
chengjiew@chengjiew-nvidia:ubuntu_20.04$```

@brycelelbach brycelelbach modified the milestones: 1.4.1, 2.0.0 Feb 25, 2021
@veictry
Copy link
Contributor Author

veictry commented Mar 3, 2021

Hi @griwes
My fixes are ready now. Please help to check again. Thanks!

@brycelelbach brycelelbach added P1: should have Important but not necessary for release. only: tests Changes to tests only. labels Mar 29, 2021
@brycelelbach brycelelbach changed the title add clang-11 docker configurations Add clang-11 docker configurations Mar 29, 2021
@wmaxey
Copy link
Member

wmaxey commented Feb 18, 2022

@veictry I've gone ahead and added several new compilers in #251. Will be closing this PR.

@wmaxey wmaxey closed this Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
only: tests Changes to tests only. P1: should have Important but not necessary for release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants