-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files have DOS line endings, please convert to Unix line endings.
Also, I tried running this with a compiler from the dev branch from today and it still says that clang 11 isn't a supported host compiler...
@@ -0,0 +1,109 @@ | |||
# Dockerfile for libcudacxx_base:host_x86_64_ubuntu_20.04__target_x86_64_ubuntu_20.04__clang_10_cxx_11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the comments to refer to Clang 11 and not 10. (Same for the other files.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@griwes
Thanks Michal!
I'll modify them right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@griwes
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the converting from DOS line endings to Unix line endings, I'll try to fix it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done the last task. (submitted by my own Github account)
Actually ignore the compiler comment, seems my dev environment wasn't completely built, works after applying dos2unix. The rest of the comments stand. |
The variant_configuration.bash files still have windows line endings. Can you fix that and squash all the commits into a single one? |
The line ending issue has been fixed and the commit is modified. |
All windows line ending were changed to unix line ending chengjiew@chengjiew-nvidia:ubuntu_20.04$ git reset --hard
HEAD is now at 6000513 add clang-11 docker configurations
chengjiew@chengjiew-nvidia:ubuntu_20.04$ grep -lR $'\r'
chengjiew@chengjiew-nvidia:ubuntu_20.04$``` |
Hi @griwes |
Based on nvbug https://nvbugs/200700358
added the required docker configuration related to the build with Clang-11
The image is based on Ubuntu 20.04.
In addition, we define DEBIAN_FRONTEND and TZ in docker layer.