Updates for DCGM 3.3.0 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you looked at testing/python3/internal_scripts/nvswitch_counter_monitor.py? It uses some of the fields you are deleting. Well, from the python equivalent of dcgm_fields.h, but that should follow dcgm_fields.h. |
nikkon-dev
approved these changes
Nov 7, 2023
|
The deleted fields are no longer present in dcgm_fields.h. Most likely nvswitch_counter_monitor.py needs to be updated. |
|
No, more than that: dcgm_fields.py has to match dcgm_fields.h. I did not see it in your merge request. Nik: this looks incomplete. |
This is not the dcgm repo. The changes you are referring to are irrelevant for Go bindings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes fix/formatting for WatchPidFields from helinfan