Fix StridedMemoryView by deferring the check for whether a capsule is versioned
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
added
bug
|
@yangcal could you test this instead? |
|
/ok to test |
|
/ok to test |
ksimpson-work
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Approved and locally verified
import jax.numpy as jnp
import jax
from cuda.core.experimental.utils import args_viewable_as_strided_memory
from cuda.core.experimental import Device
@args_viewable_as_strided_memory((0,))
def parse_tensor(arr):
dev = Device(0)
dev.set_current()
stream = dev.create_stream()
view = arr.view(stream.handle)
arr = jnp.array([1, 2, 3], device = jax.devices("cuda")[0])
parse_tensor(arr)
|
Thanks, Keenan! Let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #285.
xref: #285 (comment)