This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix clang compile error #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I'll run this through our CI in the next week or so. Thanks for the patch! |
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Jul 8, 2021
|
Rebased to pull in recent CI fixes. DVS CL: 30167018 |
alliepiper
added
testing: gpuCI in progress
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Jul 21, 2021
|
Rebased for more CI fixes... DVS CL: 30211046 |
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Feb 16, 2022
This makes RAFT sources compilable with clang. It fixes some fragile code (using `static const` instead of `static constexpr` or `%laneid` in PTX relying on quirks in nvcc which make this happen). RAFT is still not compilable with clang entirely though due to the dependencies: 1. cub has this issue before 1.14: NVIDIA/cub#335 2. libcudacxx has issues with atomic, which should be fixed in >= 1.7.0-ea (wasn't able to verify this yet) 3. libcudacxx has issues with variadic CUDA functions, which is apparently fixed by passing `-Xclang -fcuda-allow-variadic-functions` to clang (wasn't able to verify this yet) 3. cooperative_groups from CUDA does not work with clang 11.0 / 11.1 but only with >= 13 EDIT: this is necessary to close #84 Authors: - Matt Joux (https://github.com/MatthiasKohl) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Artem M. Chirkin (https://github.com/achirkin) URL: #424
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #334