This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Allow segmented problems to have different types for offset iterators. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified segmented reduce, segmented radix sort and their tests.
alliepiper
suggested changes
May 4, 2021
|
Looks good -- thanks again for this! I know these large, tedious refactorings aren't fun, and I appreciate your effort here :) I'll kick off testing today, we should be able to get this into the next release. |
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
May 5, 2021
alliepiper
approved these changes
May 5, 2021
|
gpuCI: NVIDIA/thrust#1422 |
alliepiper
added
testing: internal ci in progress
|
Will you write me if the tests fail? I'm ready to fix bugs if you provide me with build configuration. |
|
Sure! I'll let you know how it goes. |
|
@psvvsp Tests passed, this is all set! I'll merge this PR during the next round of integrations. |
alliepiper
added
testing: internal ci passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified segmented reduce, segmented radix sort and their tests.