This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix cub/util_type.cuh to not use 16-bit float with NVC++ #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit changed several occurances of "__CUDACC_VER_MAJOR__ >= 9" in preprocessor expressions to "(__CUDACC_VER_MAJOR__ >= 9 || CUDA_VERSION >= 9000)". NVC++ defines CUDA_VERSION but not __CUDACC_VER_MAJOR__, so the commit changed the condition from false to true for NVC++. The code inside those blocks doesn't work with NVC++, causing compilation errors. Fix the regression by changing the expressions to "(__CUDACC_VER_MAJOR__ >= 9 || CUDA_VERSION >= 9000) && !__NVCOMPILER_CUDA__".
|
I have tested the change cub/util_type.cuh with NVC++. I have not tested the change to test/test_device_radix_sort.cu, because I don't have an easy way to do that. |
alliepiper
approved these changes
Nov 6, 2020
alliepiper
added
testing: internal ci passed
|
LGTM, DVS CL 29289339 is passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit changed several occurances of
__CUDACC_VER_MAJOR__ >= 9in preprocessor expressions to(__CUDACC_VER_MAJOR__ >= 9 || CUDA_VERSION >= 9000). NVC++ definesCUDA_VERSIONbut not__CUDACC_VER_MAJOR__, so the commit changed the condition from false to true for NVC++. The code inside those blocks doesn't work with NVC++, causing compilation errors. Fix the regression by changing the expressions to(__CUDACC_VER_MAJOR__ >= 9 || CUDA_VERSION >= 9000) && !__NVCOMPILER_CUDA__.