Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance unit tests by adopting consistent naming conventions. #641

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Enhance unit tests by adopting consistent naming conventions. #641

merged 6 commits into from
Nov 19, 2024

Conversation

PointKernel
Copy link
Member

This PR adopts uniform naming for unit tests, enhancing the clarity of the CTest execution log. It also relocates map find and contains unit tests into separate files to improve build efficiency.

@PointKernel PointKernel added Needs Review Awaiting reviews before merging type: improvement Improvement / enhancement to an existing function labels Nov 19, 2024
sleeepyjack
sleeepyjack approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed changes are optional.
LGTM

tests/static_map/capacity_test.cu Outdated Show resolved Hide resolved
tests/static_map/custom_type_test.cu Outdated Show resolved Hide resolved
tests/static_map/heterogeneous_lookup_test.cu Outdated Show resolved Hide resolved
tests/static_map/insert_or_assign_test.cu Outdated Show resolved Hide resolved
tests/static_map/rehash_test.cu Outdated Show resolved Hide resolved
tests/static_set/unique_sequence_test.cu Outdated Show resolved Hide resolved
tests/utility/hash_test.cu Outdated Show resolved Hide resolved
tests/utility/hash_test.cu Outdated Show resolved Hide resolved
tests/utility/hash_test.cu Outdated Show resolved Hide resolved
tests/utility/hash_test.cu Outdated Show resolved Hide resolved
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@PointKernel
Copy link
Member Author

/ok to test

@PointKernel PointKernel merged commit 644e553 into NVIDIA:dev Nov 19, 2024
18 checks passed
@PointKernel PointKernel deleted the rename-tests branch November 19, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleeepyjack sleeepyjack sleeepyjack approved these changes

Assignees
No one assigned
Labels
Needs Review Awaiting reviews before merging type: improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @sleeepyjack