Add compute_hash overloads for std::byte* to maintain backward compatibility
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
type: feature request
sleeepyjack
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
The PR itself LGTM and can be merged to unblock cugraph.
However, I find this workaround a bit nasty given that std::byte and cuda::std::byte are virtually the same thing. In my book, there should exist at least an implicit conversion between the two.
Also, I think cugraph should use cuda::std::byte here in the first place.
Agreed. I will open a cugraph PR for this once the current work is merged |
Opened rapidsai/cugraph#4707 to fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblock rapidsai/cugraph#4686
The
compute_hashfunction is a host-device function, so the appropriate argument type iscuda::std::byte. However, to ensure backward compatibility and avoid breaking existing use cases, this PR adds overloads that acceptstd::byte.