Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix try_reserve_shmem #540

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix try_reserve_shmem #540

merged 1 commit into from
Jul 13, 2024

Conversation

sleeepyjack
Copy link
Collaborator

Fixes #538

@sleeepyjack sleeepyjack added type: bug Something isn't working P0: Must have Critical feature or bug fix Needs Review Awaiting reviews before merging labels Jul 12, 2024
@sleeepyjack sleeepyjack self-assigned this Jul 12, 2024
@sleeepyjack sleeepyjack marked this pull request as ready for review July 12, 2024 23:01
@sleeepyjack sleeepyjack requested a review from PointKernel as a code owner July 12, 2024 23:01
@sleeepyjack sleeepyjack mentioned this pull request Jul 12, 2024
Closed
1 task
@sleeepyjack
Copy link
Collaborator Author

sleeepyjack commented Jul 12, 2024 •
edited
Loading

The compute-sanitizer error seems to be gone:

(cccl) coder ➜ ~/cuCollections $ compute-sanitizer build/latest/tests/DISTINCT_COUNT_ESTIMATOR_TEST
========= COMPUTE-SANITIZER
Randomness seeded to: 3319017023
===============================================================================
All tests passed (478 assertions in 8 test cases)
========= ERROR SUMMARY: 0 errors

@sleeepyjack sleeepyjack merged commit cd90ff8 into NVIDIA:dev Jul 13, 2024
15 checks passed
@sleeepyjack sleeepyjack deleted the fix-reserve-shmem branch July 13, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

Assignees

@sleeepyjack sleeepyjack

Labels
Needs Review Awaiting reviews before merging P0: Must have Critical feature or bug fix type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Compute sanitizer memcheck failed with DISTINCT_COUNT_ESTIMATOR_TEST
2 participants
@sleeepyjack @PointKernel