-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve implememtation details in experimental data structures #345
Conversation
|
Agreed. The following code will fail if the auto my_probe = cuco::experimental::double_hashing<custom_hasher>(custom_hasher{}); This makes me realize that our current code is based on the assumption that only one hasher type is used in double hashing and the second hasher must have an integer ctor: cuCollections/include/cuco/probing_scheme.cuh Line 112 in 6bc62c6
This is a too-restrictive requirement and using two identical hashers is the first step to lower the bar. I haven't figured out a way to avoid the secondary collision yet by following this idea. |
Changes reverted at 8ac0ee8 since it requires a larger scope of adjustment/cleanup and will be in a separate PR. |
This PR fixes issues and adds new features requested by rapidsai/cudf#13807.
It:
!=
operatorcapacity_test
back since several corner cases need to be exercised