Add experimental `static_map` #314

PointKernel · 2023-06-04T23:31:13Z

Contributes to #110

This PR adds experimental::static_map and involves several changes to the existing code:

Extracts common open_addressing_impl and open_addressing_ref_impl classes to minimize duplicates between map and set implementations
Updates the existing code and fixes bugs: invalid type conversion in attemp_insert, narrow conversions inside probing scheme, doc improvement, etc.

…lass

…ef_impl

…x docs, more build time checks, etc

sleeepyjack

First round of review. Lots of changes so I give it another pass. Thanks for this incredible work!

include/cuco/static_set.cuh

include/cuco/detail/static_map/static_map_ref.inl

include/cuco/detail/open_addressing_impl.cuh

include/cuco/detail/static_map/static_map.inl

include/cuco/static_map.cuh

Co-authored-by: Daniel Jünger <[email protected]>

examples/static_set/device_ref_example.cu

include/cuco/detail/common_functors.cuh

include/cuco/detail/equal_wrapper.cuh

include/cuco/detail/open_addressing_ref_impl.cuh

include/cuco/detail/static_map/static_map_ref.inl

include/cuco/static_map.cuh

include/cuco/detail/open_addressing_impl.cuh

Contributes to #110 Depends on #314 This PR: - deprecates `cuco::pair_type` alias - fixes issues with `cuco::make_pair` - separates `pair` declarations and implementation details

PointKernel added 4 commits June 4, 2023 13:03

Clean up static_set with a common open_addressing_base class

91e621c

Use PIMPL instead of inheritance

d347995

Add experimental static_map class

474b110

Minor cleanup

1fe9468

PointKernel added type: feature request New feature request topic: static_map Issue related to the static_map In Progress Currently a work in progress topic: static_set Issue related to the static_set labels Jun 4, 2023

PointKernel added this to the Refactor Open Address Data Structures milestone Jun 4, 2023

sleeepyjack marked this pull request as ready for review June 5, 2023 11:04

PointKernel marked this pull request as draft June 5, 2023 16:55

PointKernel added 19 commits June 5, 2023 10:41

Add empty value sentinel getter

31fcc88

Move retrieve_all detail to the common open_addressing_impl class

7b6e791

Update docs

ffeaf75

Move insert details to open_addressing_impl for static_set

90546fe

Update docs

af8fb7c

Move static_set contains details to the common open_addressing_impl c…

55bd286

…lass

Clean up static_set find with common open_addressing_impl class

2a3cc2f

Clean up static map host functions with open_addressing_impl

6d1c3f6

Merge remote-tracking branch 'upstream/dev' into new-static-map-v2

b220fc9

Add open_addressing_ref_impl class

f0bf8b7

Move static_set_ref find and contains to the common open_addressing_r…

2d68252

…ef_impl

Clean up static_set_ref insert functions with open_addressing_ref_impl

39cb6ce

Clean up equal wrapper

8bb5e3a

Fix logic issues with slot sentinel

e402d4a

Clean up static_map_ref with open_addressing_ref_impl

478bc2f

Update docs

b5d5ef3

Add pair equal operator

8961718

Remove static_set::find benchmark

0afb43d

Move host bulk find out of common headers

25d1255

PointKernel added 5 commits June 12, 2023 11:46

various static_set detail cleanups

68d7936

Update copyright year

7be04e2

Updates: use struct instead of cuco pair for intermediate results, fi…

8978dbd

…x docs, more build time checks, etc

Remove redundant allocator data member

58f2a74

Rename predicate as key_eq to align with STL naming convension

e19d5f8

sleeepyjack reviewed Jun 12, 2023

View reviewed changes

PointKernel mentioned this pull request Jun 13, 2023

[ENHANCEMENT]: Add insert_or_assign for static_map #317

Closed

PointKernel and others added 7 commits June 13, 2023 10:46

Apply suggestions from code review

fe9818f

Co-authored-by: Daniel Jünger <[email protected]>

[pre-commit.ci] auto code formatting

f4f8369

Rename impl data members

37f4166

Change the default allocator types

b5b4d66

Minor doc updates

1cfa9dd

Add error check for non-CG device APIs to prevent misuse

484a72e

Update error message

96ae321

PointKernel requested a review from sleeepyjack June 14, 2023 00:32

PointKernel added 2 commits June 13, 2023 17:34

Reorder header groups

f6dca60

Always pass CG by reference

02c2584

PointKernel mentioned this pull request Jun 14, 2023

Make XXHash the default hash function #318

Merged

Clean up redundant header inclusions

7492471

PointKernel mentioned this pull request Jun 20, 2023

Clean up cuco::pair #319

Merged

sleeepyjack reviewed Jun 21, 2023

View reviewed changes

PointKernel added 2 commits June 21, 2023 11:13

Make functor constructions explicit

d06ce04

Clean up docs and comment

161dc7b

PointKernel requested a review from sleeepyjack June 22, 2023 00:06

sleeepyjack reviewed Jun 22, 2023

View reviewed changes

include/cuco/detail/open_addressing_impl.cuh Outdated Show resolved Hide resolved

Update static asserts

be75468

PointKernel requested a review from sleeepyjack June 22, 2023 21:24

PointKernel merged commit c0cce86 into NVIDIA:dev Jun 23, 2023

PointKernel deleted the new-static-map-v2 branch June 23, 2023 01:02

PointKernel added a commit that referenced this pull request Jun 27, 2023

Clean up cuco::pair (#319)

88ff1e4

Contributes to #110 Depends on #314 This PR: - deprecates `cuco::pair_type` alias - fixes issues with `cuco::make_pair` - separates `pair` declarations and implementation details

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add experimental `static_map` #314

Add experimental `static_map` #314

PointKernel commented Jun 4, 2023 •

edited

Loading

sleeepyjack left a comment

Add experimental static_map #314

Add experimental static_map #314

Conversation

PointKernel commented Jun 4, 2023 • edited Loading

sleeepyjack left a comment

Choose a reason for hiding this comment

Add experimental `static_map` #314

Add experimental `static_map` #314

PointKernel commented Jun 4, 2023 •

edited

Loading