-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply sentinel namespace to other map structures #163
Conversation
Can one of the admins verify this patch? |
@m3g4d1v3r Thanks for the contribution!
Which version of host compiler are you using? Include |
ok to test |
Hello @PointKernel and @ajschmidt8 . The inclusion of
I've used the following command to prepare the build environment:
|
Thanks @m3g4d1v3r! It looks like you're trying to compile with clang. We don't explicitly support this, though it is something we're looking into: #128 |
I see @jrhemstad! I guess I was confused about which compiler to use, so I ended up trying to compile with clang and supposed that I was missing some configuration in the cmake step. Following your suggestions, I've successfully compiled the project the pull request diff using gcc version 10.2.1 for Debian. As for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small suggestions then it should be good to go.
@@ -52,7 +52,7 @@ static_multimap<Key, Value, Scope, Allocator, ProbeSequence>::static_multimap( | |||
auto const grid_size = (get_capacity() + stride * block_size - 1) / (stride * block_size); | |||
|
|||
detail::initialize<atomic_key_type, atomic_mapped_type><<<grid_size, block_size, 0, stream>>>( | |||
slots_.get(), empty_key_sentinel, empty_value_sentinel, get_capacity()); | |||
slots_.get(), empty_key_sentinel_, empty_value_sentinel_, get_capacity()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Thanks again @m3g4d1v3r |
Closes #162
Hello there!
This is my first contribution to a open source project, so please bear with me if I make a mistake or two.
I've tried to compile the last changes on my linux machine but unfortunately I've reached some errors at the benchmark compiling step.
Regarding the commits, I've managed to find two structures that the sentinel namespace could be applied. Please let me know if there are other structures that I've missed or if there were errors in my commits.
Best regards,
Marlon