-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of get_ prefixes #157
Conversation
Can one of the admins verify this patch? |
okay to test |
Can you Please tell me what mistakes i have made and how i can correct them. |
@vighnesh-kadam You renamed all related APIs in |
Okay got it ! I will get it done. |
I am not able to build the repo locally . i keep getting the following error after i run
|
@vighnesh-kadam Looks like you are invoking CMake command in the wrong folder. In geneal, you want to create a new folder in |
ok i will try the build again in ubuntu |
I was able to install cmake on my ubuntu sys. but the problem is im not able to install cuda toolkit hence im not able to get the nvcc compiler , i tried insalling deb and local run from here toolkit install but failed . |
Have you tried the apt install? i.e. sudo apt update
sudo apt install nvidia-cuda-toolkit Otherwise, you can use a docker image to just compile the code. e.g. https://hub.docker.com/r/nvidia/cuda |
yes i tried the sudo apt commands but still got many errors |
auto const num_keys = state.int64("NumInputs"); | ||
auto const occupancy = state.float64("Occupancy"); | ||
auto const matching_rate = state.float64("MatchingRate"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto const num_keys = state.int64("NumInputs"); | |
auto const occupancy = state.float64("Occupancy"); | |
auto const matching_rate = state.float64("MatchingRate"); | |
auto const num_keys = state.get_int64("NumInputs"); | |
auto const occupancy = state.get_float64("Occupancy"); | |
auto const matching_rate = state.get_float64("MatchingRate"); |
Closing this issue as it's stale and will be implicitly fixed by #110 |
Thank you for contributing to PROJECT :)
Here are some guidelines to help the review process go smoothly.
Please write a description in this text box of the changes that are being
made.
Get rid of get_ prefixes
Please ensure that you have written units tests for the changes made/features
added.
If you are closing an issue please use one of the automatic closing words as
noted here: https://help.github.com/articles/closing-issues-using-keywords/
Closes #1478
If your pull request is not ready for review but you want to make use of the
continuous integration testing facilities please label it with
[WIP]
.If your pull request is ready to be reviewed without requiring additional
work on top of it, then remove the
[WIP]
label (if present) and replaceit with
[REVIEW]
. If assistance is required to complete the functionality,for example when the C/C++ code of a feature is complete but Python bindings
are still required, then add the label
[HELP-REQ]
so that others can triageand assist. The additional changes then can be implemented on top of the
same PR. If the assistance is done by members of the rapidsAI team, then no
additional actions are required by the creator of the original PR for this,
otherwise the original author of the PR needs to give permission to the
person(s) assisting to commit to their personal fork of the project. If that
doesn't happen then a new PR based on the code of the original PR can be
opened by the person assisting, which then will be the PR that will be
merged.
Once all work has been done and review has taken place please do not add
features or make changes out of the scope of those requested by the reviewer
(doing this just add delays as already reviewed code ends up having to be
re-reviewed/it is hard to tell what is new etc!). Further, please do not
rebase your branch on master/force push/rewrite history, doing any of these
causes the context of any comments made by reviewers to be lost. If
conflicts occur against master they should be resolved by merging master
into the branch used for making the pull request.
Many thanks in advance for your cooperation!