Use rapids_cpm_libcudacxx to support installed libcudacxx #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if an installed version of libcudacxx is found, the install paths computed in get_libcudacxx are wrong. Resolve this issue by instead using rapids-cmake
robertmaynard
force-pushed
the
move_over_to_rapids_libcudacxx
branch
from
cb4dd12 to
bf6a90d
Compare
jrhemstad
reviewed
Nov 2, 2021
| endfunction() | ||
|
|
||
| find_and_configure_libcudacxx(1.4.0) | ||
| find_and_configure_libcudacxx() |
There was a problem hiding this comment.
How do we specify a version or git hash now?
There was a problem hiding this comment.
Talked with @robertmaynard , and here's the solution we have for now.
jrhemstad
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an installed version of libcudacxx is found, the install paths computed in get_libcudacxx are wrong. Resolve this issue by instead using rapids-cmake