Skip to content

Commit

Permalink
Make member access explicitly qualified for clang 17
Browse files Browse the repository at this point in the history
Clang complains:

  external/com_github_nvidia_cuco/include/cuco/detail/static_map.inl:446:21: error:
        explicit qualification required to use member 'initial_slot' from dependent base class
    446 |   auto current_slot{initial_slot(insert_pair.first, hash)};
        |                     ^
  frc971/orin/cuda.cc:219:32: note: in instantiation of function template
        specialization 'cuco::static_map<unsigned long, unsigned
        long>::device_mutable_view::insert_and_find<cuco::detail::XXHash_32<unsigned long>,
        thrust::equal_to<unsigned long>>' requested here
    219 |   auto [iter, inserted] = view.insert_and_find(thrust::make_pair(union_markers[i], 1));
        |                                ^

Signed-off-by: Austin Schuh <[email protected]>
  • Loading branch information
AustinSchuh committed Nov 18, 2023
1 parent 18c9709 commit 5dc8e6c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/cuco/detail/static_map.inl
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ __device__
"insert_and_find is not supported for unpackable data on pre-Volta GPUs.");
#endif

auto current_slot{initial_slot(insert_pair.first, hash)};
auto current_slot{this->initial_slot(insert_pair.first, hash)};

while (true) {
key_type const existing_key = current_slot->first.load(cuda::std::memory_order_relaxed);
Expand Down Expand Up @@ -514,7 +514,7 @@ __device__

// if we couldn't insert the key, but it wasn't a duplicate, then there must
// have been some other key there, so we keep looking for a slot
current_slot = next_slot(current_slot);
current_slot = this->next_slot(current_slot);
}
}

Expand Down

0 comments on commit 5dc8e6c

Please sign in to comment.