Skip to content

Commit

Permalink
Fix doxygen check with unsupported version. (#344)
Browse files Browse the repository at this point in the history
While running `pre-commit`, I got this error:

```bash
./ci/checks/doxygen.sh: line 19: : command not found
./ci/checks/doxygen.sh: line 20: : command not found
./ci/checks/doxygen.sh: line 21: : command not found
```

I have doxygen 1.9.7 installed, which isn't a supported version in this
script. The Doxygen check is supposed to pass silently when run locally
with an unsupported version (it runs properly in CI, instead).

It seems like there's an unrecognized symbol in the bash script from PR
#177:
05fb1db

This PR removes that symbol, fixing the error.
  • Loading branch information
bdice authored Aug 2, 2023
1 parent 3fe5704 commit 3d577bf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ci/checks/doxygen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ function version { echo "$@" | awk -F. '{ printf("%d%03d%03d%03d\n", $1,$2,$3,$4
# Doxygen supported version 1.8.20 to 1.9.1
DOXYGEN_VERSION=$(doxygen --version)
if [ $(version "$DOXYGEN_VERSION") -lt $(version "1.8.20") ] || [ $(version $DOXYGEN_VERSION) -gt $(version "1.9.1") ]; then
echo -e "Warning: Unsupported Doxygen version $DOXYGEN_VERSION"
echo -e "Expecting Doxygen version from 1.8.20 to 1.9.1"
exit 0
echo -e "Warning: Unsupported Doxygen version $DOXYGEN_VERSION"
echo -e "Expecting Doxygen version from 1.8.20 to 1.9.1"
exit 0
fi

# Run doxygen, ignore missing tag files error
Expand Down

0 comments on commit 3d577bf

Please sign in to comment.