Fix CubDebug #430
Merged
Fix CubDebug #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
requested review from
elstehle and
wmaxey
and removed request for
a team
miscco
approved these changes
Sep 12, 2023
elstehle
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #304
CubDebugis used to report (and reset) CUDA errors. Since CUDA errors are asynchronous, it's possible that the error provided asCubDebugargument iscudaSuccess, but the error returned fromcudaGetLastErrorinsideCubDebugis not. Current code organization leads to loosing the error returned fromcudaGetLastError. In its turn, this lead to proceeding execution of CUB algorithms instead of returning an error to the user.This PR fixes
CubDebugto returncudaGetLastErrorresult if the input error is notcudaSuccess. This change necessitates fixing most of theCubDebugusages to store the error returned fromCubDebug. Without this PR, it's difficult to identify issues that are caused by #166.Checklist