You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i see i'm a bit late. i have a question, though. these allocation routines call cuda runtime apis using the _CCCL_TRY_CUDA_API macro. that macro throws a cuda_error on failure. i wonder if those should throw bad_alloc instead. i don't know the answer.
i see i'm a bit late. i have a question, though. these allocation routines call cuda runtime apis using the _CCCL_TRY_CUDA_API macro. that macro throws a cuda_error on failure. i wonder if those should throw bad_alloc instead. i don't know the answer.
For now we decided that we wanted to always use the cuda error because that actually might help the user rather than a generic bad_alloc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups that came from cudax work, but will just make CI worse for that