-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small tuning script output improvements #2262
Merged
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
commented
Aug 19, 2024
@@ -19,7 +19,7 @@ def first_val(my_dict): | |||
first_value = values[0] | |||
|
|||
if not all(value == first_value for value in values): | |||
raise ValueError('All values in the dictionary are not equal') | |||
raise ValueError('All values in the dictionary are not equal. First value: {} All values: {}'.format(first_value, values)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outputing values
is verbose, but otherwise you have no clue what is actually wrong.
4d9a568
to
97a1e35
Compare
gevtushenko
approved these changes
Aug 20, 2024
miscco
approved these changes
Aug 20, 2024
🟩 CI finished in 12h 31m: Pass: 100%/421 | Total: 2d 04h | Avg: 7m 30s | Max: 49m 44s | Hits: 94%/34092
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 421)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
65 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Aug 20, 2024
* Report mismatched values in first_val * Improve output while search.py is running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a few small output improvements when running
search.py
from the tuning infrastructure.