Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure CUB/Thrust for C++17 by default #2217

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

bernhardmgruber
Copy link
Contributor

Since we recently added a deprecation warning for C++14 in CUB and Thrust (#2165), we should also configure those projects to C++17 by default. This avoids users not using our cmake presets to get flooded by warnings.

@bernhardmgruber bernhardmgruber added cub For all items related to CUB thrust For all items related to Thrust. labels Aug 12, 2024
@bernhardmgruber bernhardmgruber marked this pull request as ready for review August 12, 2024 09:13
@bernhardmgruber bernhardmgruber requested review from a team as code owners August 12, 2024 09:13
Copy link
Contributor

🟩 CI finished in 2d 07h: Pass: 100%/250 | Total: 1d 05h | Avg: 6m 59s | Max: 34m 37s | Hits: 98%/14811
  • 🟩 cub: Pass: 100%/131 | Total: 17h 44m | Avg: 8m 07s | Max: 25m 13s | Hits: 99%/4254

    🟩 cpu
      🟩 amd64              Pass: 100%/123 | Total: 17h 07m | Avg:  8m 21s | Max: 25m 13s | Hits:  99%/4254  
      🟩 arm64              Pass: 100%/8   | Total: 37m 16s | Avg:  4m 39s | Max:  5m 28s
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total:  1h 03m | Avg:  4m 14s | Max: 12m 43s | Hits:  99%/709   
      🟩 11.8               Pass: 100%/3   | Total: 13m 30s | Avg:  4m 30s | Max:  4m 46s
      🟩 12.5               Pass: 100%/113 | Total: 16h 27m | Avg:  8m 44s | Max: 25m 13s | Hits:  99%/3545  
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 14s | Avg:  3m 37s | Max:  3m 42s
      🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 03m | Avg:  4m 14s | Max: 12m 43s | Hits:  99%/709   
      🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 30s | Avg:  4m 30s | Max:  4m 46s
      🟩 nvcc12.5           Pass: 100%/111 | Total: 16h 20m | Avg:  8m 49s | Max: 25m 13s | Hits:  99%/3545  
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 14s | Avg:  3m 37s | Max:  3m 42s
      🟩 nvcc               Pass: 100%/129 | Total: 17h 37m | Avg:  8m 11s | Max: 25m 13s | Hits:  99%/4254  
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total: 26m 40s | Avg:  4m 26s | Max:  5m 05s
      🟩 Clang10            Pass: 100%/3   | Total: 15m 17s | Avg:  5m 05s | Max:  5m 26s
      🟩 Clang11            Pass: 100%/4   | Total: 17m 53s | Avg:  4m 28s | Max:  4m 41s
      🟩 Clang12            Pass: 100%/4   | Total: 18m 24s | Avg:  4m 36s | Max:  5m 02s
      🟩 Clang13            Pass: 100%/4   | Total: 17m 56s | Avg:  4m 29s | Max:  4m 57s
      🟩 Clang14            Pass: 100%/4   | Total: 18m 20s | Avg:  4m 35s | Max:  4m 57s
      🟩 Clang15            Pass: 100%/4   | Total: 18m 17s | Avg:  4m 34s | Max:  5m 18s
      🟩 Clang16            Pass: 100%/4   | Total: 18m 04s | Avg:  4m 31s | Max:  4m 39s
      🟩 Clang17            Pass: 100%/26  | Total:  5h 42m | Avg: 13m 11s | Max: 25m 13s
      🟩 GCC6               Pass: 100%/2   | Total:  7m 26s | Avg:  3m 43s | Max:  3m 56s
      🟩 GCC7               Pass: 100%/6   | Total: 23m 52s | Avg:  3m 58s | Max:  4m 27s
      🟩 GCC8               Pass: 100%/6   | Total: 22m 55s | Avg:  3m 49s | Max:  4m 25s
      🟩 GCC9               Pass: 100%/6   | Total: 23m 19s | Avg:  3m 53s | Max:  4m 37s
      🟩 GCC10              Pass: 100%/4   | Total: 17m 35s | Avg:  4m 23s | Max:  4m 59s
      🟩 GCC11              Pass: 100%/7   | Total: 30m 51s | Avg:  4m 24s | Max:  4m 46s
      🟩 GCC12              Pass: 100%/4   | Total: 18m 40s | Avg:  4m 40s | Max:  4m 53s
      🟩 GCC13              Pass: 100%/28  | Total:  5h 47m | Avg: 12m 24s | Max: 24m 49s
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 14m 56s | Avg:  4m 58s | Max:  5m 02s
      🟩 MSVC14.16          Pass: 100%/1   | Total: 12m 43s | Avg: 12m 43s | Max: 12m 43s | Hits:  99%/709   
      🟩 MSVC14.29          Pass: 100%/2   | Total: 19m 56s | Avg:  9m 58s | Max: 10m 28s | Hits:  99%/1418  
      🟩 MSVC14.39          Pass: 100%/3   | Total: 30m 59s | Avg: 10m 19s | Max: 11m 21s | Hits:  99%/2127  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/59  | Total:  8h 13m | Avg:  8m 22s | Max: 25m 13s
      🟩 GCC                Pass: 100%/63  | Total:  8h 12m | Avg:  7m 48s | Max: 24m 49s
      🟩 Intel              Pass: 100%/3   | Total: 14m 56s | Avg:  4m 58s | Max:  5m 02s
      🟩 MSVC               Pass: 100%/6   | Total:  1h 03m | Avg: 10m 36s | Max: 12m 43s | Hits:  99%/4254  
    🟩 gpu
      🟩 v100               Pass: 100%/131 | Total: 17h 44m | Avg:  8m 07s | Max: 25m 13s | Hits:  99%/4254  
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  7h 49m | Avg:  4m 44s | Max: 12m 43s | Hits:  99%/4254  
      🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 25m | Avg: 18m 11s | Max: 19m 18s
      🟩 GraphCapture       Pass: 100%/8   | Total:  2h 03m | Avg: 15m 23s | Max: 17m 11s
      🟩 HostLaunch         Pass: 100%/8   | Total:  2h 20m | Avg: 17m 32s | Max: 19m 47s
      🟩 TestGPU            Pass: 100%/8   | Total:  3h 06m | Avg: 23m 15s | Max: 25m 13s
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 30s | Avg:  4m 30s | Max:  4m 46s
      🟩 90a                Pass: 100%/4   | Total: 14m 16s | Avg:  3m 34s | Max:  3m 45s
    🟩 std
      🟩 11                 Pass: 100%/34  | Total:  4h 16m | Avg:  7m 32s | Max: 24m 52s
      🟩 14                 Pass: 100%/37  | Total:  4h 52m | Avg:  7m 54s | Max: 22m 23s | Hits:  99%/2127  
      🟩 17                 Pass: 100%/36  | Total:  4h 43m | Avg:  7m 52s | Max: 24m 49s | Hits:  99%/1418  
      🟩 20                 Pass: 100%/24  | Total:  3h 52m | Avg:  9m 40s | Max: 25m 13s | Hits:  99%/709   
    
  • 🟩 thrust: Pass: 100%/118 | Total: 11h 10m | Avg: 5m 41s | Max: 34m 37s | Hits: 98%/10557

    🟩 cpu
      🟩 amd64              Pass: 100%/110 | Total: 10h 10m | Avg:  5m 32s | Max: 34m 37s | Hits:  98%/10557 
      🟩 arm64              Pass: 100%/8   | Total:  1h 00m | Avg:  7m 31s | Max: 31m 34s
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total: 58m 04s | Avg:  3m 52s | Max: 14m 07s | Hits:  98%/1173  
      🟩 11.8               Pass: 100%/3   | Total: 10m 52s | Avg:  3m 37s | Max:  4m 01s
      🟩 12.5               Pass: 100%/100 | Total: 10h 01m | Avg:  6m 01s | Max: 34m 37s | Hits:  98%/9384  
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s
      🟩 nvcc11.1           Pass: 100%/15  | Total: 58m 04s | Avg:  3m 52s | Max: 14m 07s | Hits:  98%/1173  
      🟩 nvcc11.8           Pass: 100%/3   | Total: 10m 52s | Avg:  3m 37s | Max:  4m 01s
      🟩 nvcc12.5           Pass: 100%/98  | Total:  9h 54m | Avg:  6m 04s | Max: 34m 37s | Hits:  98%/9384  
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s
      🟩 nvcc               Pass: 100%/116 | Total: 11h 03m | Avg:  5m 43s | Max: 34m 37s | Hits:  98%/10557 
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total: 22m 43s | Avg:  3m 47s | Max:  4m 40s
      🟩 Clang10            Pass: 100%/3   | Total: 13m 21s | Avg:  4m 27s | Max:  4m 46s
      🟩 Clang11            Pass: 100%/4   | Total: 14m 27s | Avg:  3m 36s | Max:  3m 50s
      🟩 Clang12            Pass: 100%/4   | Total: 14m 11s | Avg:  3m 32s | Max:  3m 41s
      🟩 Clang13            Pass: 100%/4   | Total: 14m 44s | Avg:  3m 41s | Max:  3m 54s
      🟩 Clang14            Pass: 100%/4   | Total: 14m 33s | Avg:  3m 38s | Max:  3m 42s
      🟩 Clang15            Pass: 100%/4   | Total: 15m 06s | Avg:  3m 46s | Max:  3m 58s
      🟩 Clang16            Pass: 100%/4   | Total: 14m 38s | Avg:  3m 39s | Max:  3m 48s
      🟩 Clang17            Pass: 100%/18  | Total:  1h 58m | Avg:  6m 33s | Max: 15m 39s
      🟩 GCC6               Pass: 100%/2   | Total:  6m 14s | Avg:  3m 07s | Max:  3m 12s
      🟩 GCC7               Pass: 100%/6   | Total: 19m 08s | Avg:  3m 11s | Max:  3m 31s
      🟩 GCC8               Pass: 100%/6   | Total: 20m 46s | Avg:  3m 27s | Max:  3m 42s
      🟩 GCC9               Pass: 100%/6   | Total: 19m 21s | Avg:  3m 13s | Max:  3m 35s
      🟩 GCC10              Pass: 100%/4   | Total: 14m 21s | Avg:  3m 35s | Max:  3m 44s
      🟩 GCC11              Pass: 100%/7   | Total: 25m 36s | Avg:  3m 39s | Max:  4m 01s
      🟩 GCC12              Pass: 100%/4   | Total: 15m 35s | Avg:  3m 53s | Max:  3m 59s
      🟩 GCC13              Pass: 100%/20  | Total:  2h 53m | Avg:  8m 40s | Max: 34m 37s
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 35s | Avg:  4m 31s | Max:  4m 34s
      🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 07s | Avg: 14m 07s | Max: 14m 07s | Hits:  98%/1173  
      🟩 MSVC14.29          Pass: 100%/2   | Total: 21m 07s | Avg: 10m 33s | Max: 11m 02s | Hits:  98%/2346  
      🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 25m | Avg: 14m 15s | Max: 17m 43s | Hits:  98%/7038  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/51  | Total:  4h 01m | Avg:  4m 44s | Max: 15m 39s
      🟩 GCC                Pass: 100%/55  | Total:  4h 54m | Avg:  5m 21s | Max: 34m 37s
      🟩 Intel              Pass: 100%/3   | Total: 13m 35s | Avg:  4m 31s | Max:  4m 34s
      🟩 MSVC               Pass: 100%/9   | Total:  2h 00m | Avg: 13m 25s | Max: 17m 43s | Hits:  98%/10557 
    🟩 gpu
      🟩 v100               Pass: 100%/118 | Total: 11h 10m | Avg:  5m 41s | Max: 34m 37s | Hits:  98%/10557 
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  7h 19m | Avg:  4m 26s | Max: 31m 34s | Hits:  98%/7038  
      🟩 TestCPU            Pass: 100%/11  | Total:  1h 41m | Avg:  9m 11s | Max: 17m 43s | Hits:  98%/3519  
      🟩 TestGPU            Pass: 100%/8   | Total:  2h 10m | Avg: 16m 17s | Max: 34m 37s
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 10m 52s | Avg:  3m 37s | Max:  4m 01s
      🟩 90a                Pass: 100%/4   | Total: 13m 05s | Avg:  3m 16s | Max:  3m 31s
    🟩 std
      🟩 11                 Pass: 100%/30  | Total:  2h 10m | Avg:  4m 20s | Max: 14m 29s
      🟩 14                 Pass: 100%/34  | Total:  3h 37m | Avg:  6m 24s | Max: 31m 34s | Hits:  98%/4692  
      🟩 17                 Pass: 100%/33  | Total:  2h 54m | Avg:  5m 17s | Max: 17m 12s | Hits:  98%/3519  
      🟩 20                 Pass: 100%/21  | Total:  2h 28m | Avg:  7m 03s | Max: 34m 37s | Hits:  98%/2346  
    
  • 🟩 pycuda: Pass: 100%/1 | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s

    🟩 cpu
      🟩 amd64              Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    🟩 ctk
      🟩 12.5               Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    🟩 cudacxx
      🟩 nvcc12.5           Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    🟩 cxx
      🟩 GCC13              Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    🟩 cxx_family
      🟩 GCC                Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    🟩 gpu
      🟩 v100               Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    🟩 jobs
      🟩 Test               Pass: 100%/1   | Total: 10m 50s | Avg: 10m 50s | Max: 10m 50s
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
pycuda

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- pycuda

🏃‍ Runner counts (total jobs: 250)

# Runner
178 linux-amd64-cpu16
41 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber self-assigned this Aug 14, 2024
@bernhardmgruber bernhardmgruber merged commit cbce14b into NVIDIA:main Aug 14, 2024
267 checks passed
@bernhardmgruber bernhardmgruber deleted the default17 branch August 14, 2024 16:44
pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cub For all items related to CUB thrust For all items related to Thrust.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants