-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for large number of items to DeviceScan
#2171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟨 CI finished in 9h 34m: Pass: 99%/250 | Total: 6d 00h | Avg: 34m 37s | Max: 1h 11m | Hits: 70%/248308
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
elstehle
force-pushed
the
enh/offset-device-scan
branch
from
August 5, 2024 14:01
12e1a9f
to
746b108
Compare
Performance numbers look good. h100 exclusive.max, CTK 12.5results
h100 exclusive.sum, CTK 12.5results
h100 exclusive.max, CTK 12.3results
h100 exclusive.sum, CTK 12.3results
|
🟨 CI finished in 2h 56m: Pass: 98%/250 | Total: 5d 10h | Avg: 31m 12s | Max: 1h 04m | Hits: 73%/247441
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 15h 08m: Pass: 100%/250 | Total: 5d 11h | Avg: 31m 27s | Max: 1h 04m | Hits: 73%/250042
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
bernhardmgruber
approved these changes
Aug 12, 2024
🟩 CI finished in 7h 17m: Pass: 100%/250 | Total: 6d 00h | Avg: 34m 42s | Max: 1h 05m | Hits: 67%/17283
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
gevtushenko
approved these changes
Aug 19, 2024
CUB_RUNTIME_FUNCTION static cudaError_t InclusiveSum( | ||
void* d_temp_storage, size_t& temp_storage_bytes, IteratorT d_data, int num_items, cudaStream_t stream = 0) | ||
void* d_temp_storage, size_t& temp_storage_bytes, IteratorT d_data, NumItemsT num_items, cudaStream_t stream = 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: when this PR is merged, it'd be good to consider contributing a replacement for:
🟨 CI finished in 5h 21m: Pass: 90%/250 | Total: 6d 04h | Avg: 35m 35s | Max: 1h 28m | Hits: 53%/17283
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 11h 08m: Pass: 100%/250 | Total: 6d 03h | Avg: 35m 19s | Max: 1h 28m | Hits: 53%/17283
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Aug 21, 2024
* make DeviceScan offset type a template parameter * updates tests to use device interface * moves thrust scan to unsigned offset types * adjusts benchmarks to account for used offset types * uses dynamic dispatch to unsigned type * adds tparam docs for NumItemsT * fixes warning about different signedness comparison * adds check for negative num_items in thrust::scan * fixes unused param in is_negative
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Aug 23, 2024
* make DeviceScan offset type a template parameter * updates tests to use device interface * moves thrust scan to unsigned offset types * adjusts benchmarks to account for used offset types * uses dynamic dispatch to unsigned type * adds tparam docs for NumItemsT * fixes warning about different signedness comparison * adds check for negative num_items in thrust::scan * fixes unused param in is_negative
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2062
Currently opened as a draft PR while waiting for resources to perform performance assessments.
Remaining tasks:
Note,
DeviceScan::*ByKey
is not yet enabled with this PR.Checklist