-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thrust::inclusive_scan with init_value support #1940
Conversation
36a15ee
to
6ded94d
Compare
🟨 CI finished in 2h 38m: Pass: 95%/250 | Total: 5d 00h | Avg: 28m 51s | Max: 1h 03m | Hits: 51%/234548
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
6ded94d
to
818d8ce
Compare
ad28931
to
4d20bc3
Compare
🟨 CI finished in 2h 32m: Pass: 99%/250 | Total: 4d 19h | Avg: 27m 45s | Max: 1h 06m | Hits: 63%/247487
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
acbda35
to
1d71fac
Compare
096ee7a
to
2896217
Compare
🟨 CI finished in 2h 08m: Pass: 99%/250 | Total: 1d 11h | Avg: 8m 34s | Max: 42m 04s | Hits: 98%/245987
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
2896217
to
be69c01
Compare
🟨 CI finished in 2h 24m: Pass: 99%/250 | Total: 1d 09h | Avg: 8m 06s | Max: 30m 20s | Hits: 99%/246633
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 2d 19h: Pass: 100%/250 | Total: 1d 10h | Avg: 8m 18s | Max: 35m 42s | Hits: 99%/248341
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some first feedback. I have no idea how the thrust async stuff works so I have to leave this to other reviewers.
Furthermore, I wondered in some cases whether the implementation correctly handles non-commutative operations (e.g. thrust::minus).
Latest commit also resolves #2279 |
6ae0978
to
ddc29ba
Compare
ddc29ba
to
39f6f5a
Compare
🟨 CI finished in 8h 58m: Pass: 99%/417 | Total: 8d 07h | Avg: 28m 46s | Max: 1h 14m | Hits: 52%/34168
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the remaining open suggestions. Otherwise LGTM.
…nit and binary_op
39f6f5a
to
1b160d2
Compare
1b160d2
to
611e661
Compare
🟩 CI finished in 9h 09m: Pass: 100%/417 | Total: 7d 08h | Avg: 25m 28s | Max: 1h 09m | Hits: 81%/34228
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
* Add thrust::inclusive_scan with init value sequential * Add thrust::inclusive_scan cuda par with init value * Add thrust::async::incluisve_scan with init value * Add thrust::inclusive_scan tbb with init value * Handle reviews * Consolidate init overloads into a single overload that accepts both init and binary_op * Fix formatting issues * Add cuda::std::accumulator_t and use it for value_type in scan algorithms * Redo Bernhard's work and consolidate the two tbb::inclusive_scan bodies * Handle final reviews * Replace cub::accumulator_t with cuda::std::__accumulator_t
Adds
thrust::inclusive_scan
overload with initial value support for all the back-ends (seq, cuda, omp, tbb).Fixes #693.
Builds on top of #1845.